Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][Menu]: Opening Menu with declarative open and opener props does not work on the Phone. #6761

Closed
1 task done
BennyHuang opened this issue Mar 21, 2023 · 2 comments · Fixed by #8367
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code SAP SF TOPIC B

Comments

@BennyHuang
Copy link

Describe the bug

Opening Menu with declarative open and opener props does not work on the Phone. I tested with Safari on iPhone 13 on IOS 16.3 or Chrome with emulator iPhone 12 on Mac. The menu can not be opened with error below
image

There is no issue to open the menu in this way on desktop.

Isolated Example

https://codesandbox.io/s/ancient-cloud-jnquf4?file=/src/App.js

Reproduction steps

  1. Access https://jnquf4.csb.app/ with phone emulator provided by chrome dev tools or with safari on the phone.
  2. Click on Button OpenMenuByShowAt and observe that the menu is opened without any issue.
  3. Click on Button OpenMenuByUpdateState and observe that the menu is not opened with error.

Expected Behaviour

The menu should be opened by declarative open and opener props on the Phone.

Screenshots or Videos

RPReplay_Final1679440999.MP4

UI5 Web Components for React Version

1.8.0

UI5 Web Components Version

1.10.0

Browser

Chrome, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@BennyHuang BennyHuang added the bug This issue is a bug in the code label Mar 21, 2023
@Lukas742
Copy link
Collaborator

Hi @BennyHuang

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi colleagues,

here you can find a codeSandbox example using plain js with ui5-webcomponents that shows the issue as well: https://codesandbox.io/s/ui5-webcomponents-forked-nes7ge?file=/index.html

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Mar 22, 2023
@Neeeko
Copy link

Neeeko commented May 17, 2023

Hi, any updates on this ticket?

unazko added a commit to unazko/ui5-webcomponents that referenced this issue Feb 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- The ui5-menu elements used for sub-menus are created only once
and are being reused afterwards. They are no longer destroyed on close.
This contributes to lowering the count of the slow DOM manipulation operations.

- There is now no differentiation between mobile and desktop
device in regards to the display mechanism. In both cases
we rely on the template to do the job as the components used
for composition like ui5-list and ui5-responsive-popover do
comply with the device.

Fixes: SAP#7767
Fixes: SAP#7423
Fixes: SAP#6761
Related to: SAP#7391
@unazko unazko self-assigned this Mar 19, 2024
@unazko unazko closed this as completed in b668a50 Mar 25, 2024
ilhan007 pushed a commit that referenced this issue Mar 29, 2024
- The ui5-menu elements used for sub-menus are created only once
and are being reused afterwards. They are no longer destroyed on close.
This contributes to lowering the count of the slow DOM manipulation operations.

- There is now no differentiation between mobile and desktop
device in regards to the display mechanism. In both cases
we rely on the template to do the job as the components used
for composition like ui5-list and ui5-responsive-popover do
comply with the device.

Fixes: #7767
Fixes: #7423
Fixes: #6761
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code SAP SF TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants