-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SF][Menu]: Opening Menu with declarative open and opener props does not work on the Phone. #6761
Closed
1 task done
Comments
Hi @BennyHuang Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository. Hi colleagues, here you can find a codeSandbox example using plain js with ui5-webcomponents that shows the issue as well: https://codesandbox.io/s/ui5-webcomponents-forked-nes7ge?file=/index.html |
Hi, any updates on this ticket? |
unazko
added a commit
to unazko/ui5-webcomponents
that referenced
this issue
Feb 28, 2024
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: SAP#7767 Fixes: SAP#7423 Fixes: SAP#6761 Related to: SAP#7391
ilhan007
pushed a commit
that referenced
this issue
Mar 29, 2024
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: #7767 Fixes: #7423 Fixes: #6761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Opening Menu with declarative open and opener props does not work on the Phone. I tested with Safari on iPhone 13 on IOS 16.3 or Chrome with emulator iPhone 12 on Mac. The menu can not be opened with error below

There is no issue to open the menu in this way on desktop.
Isolated Example
https://codesandbox.io/s/ancient-cloud-jnquf4?file=/src/App.js
Reproduction steps
Expected Behaviour
The menu should be opened by declarative open and opener props on the Phone.
Screenshots or Videos
RPReplay_Final1679440999.MP4
UI5 Web Components for React Version
1.8.0
UI5 Web Components Version
1.10.0
Browser
Chrome, Safari
Operating System
No response
Additional Context
No response
Relevant log output
No response
Declaration
The text was updated successfully, but these errors were encountered: