-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[menu]: when using Menu in Table on mobile devices app crashes #7767
Comments
Hi @rvsia Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected components are developed in their repository. Also, it's not recommended rendering modals or popups inside other components. You can find out more about this here. In this case the issue is also occurring when the Hi colleagues, You can follow the steps provided by @rvsia with this codeSandbox as well. |
Thank you for pointing this up, we forget to use the portal here as it is working well for us on normal screens. In other places where we encounter issues, we use Portal. 👍 |
Hi @SAP/ui5-webcomponents-topic-b, Could you please check this issue? It's reproducible with native ui5-webcomponets as well. |
Hi colleagues, |
Hi colleagues, |
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: SAP#7767 Fixes: SAP#7423 Fixes: SAP#6761 Related to: SAP#7391
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: #7767 Fixes: #7423 Fixes: #6761
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: #7767 Fixes: #7423 Fixes: #6761
Describe the bug
When using a Menu component in Table on mobile devices, the app is crashing:
Isolated Example
https://codesandbox.io/s/smoosh-tdd-cywz6k
Reproduction steps
Expected Behaviour
Menu should be open
Screenshots or Videos
`
UI5 Web Components for React Version
latest
UI5 Web Components Version
latest
Browser
Chrome, Edge
Operating System
MacOS
Additional Context
Relevant log output
No response
Declaration
The text was updated successfully, but these errors were encountered: