buildsystem: no transitive linkage for internally used libraries #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJJ
added
improvement
if the linking is declared PUBLIC, e.g. all the python modules that link against libopenage would link to all of libopenage's dependencies again. when one of those, e.g. libnyan.so, is updated, the module will be linked again. this means if e.g. libnyan is updated, all python modules are relinked. this commit removes this transitive linking, and python modules won't be rebuilt any more.
TheJJ
force-pushed
the
private-library-linkage
branch
from
47239a7 to
bce3575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the linking is declared PUBLIC, e.g. all the python modules that
link against libopenage would link to all of libopenage's dependencies
again. when one of those, e.g. libnyan.so, is updated, the module will be
linked again. this means if e.g. libnyan is updated, all python modules
are relinked. this commit removes this transitive linking, and python
modules won't be rebuilt any more.