Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsystem: no transitive linkage for internally used libraries #1115

Merged
merged 1 commit into from
May 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libopenage/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2014-2018 the openage authors. See copying.md for legal info.
# Copyright 2014-2019 the openage authors. See copying.md for legal info.

# main C++ library definitions.
# dependency and source file setup for the resulting library.
Expand Down Expand Up @@ -270,7 +270,7 @@ target_include_directories(libopenage
# all the libraries are not exposed
# to the public api of libopenage
target_link_libraries(libopenage
PUBLIC
PRIVATE
Threads::Threads
nyan::nyan
Eigen3::Eigen
Expand Down