Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA: table right click improvements #1180

Closed
SmiteDeluxe opened this issue May 26, 2024 · 3 comments · Fixed by #1213
Closed

EDA: table right click improvements #1180

SmiteDeluxe opened this issue May 26, 2024 · 3 comments · Fixed by #1213
Assignees
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension

Comments

@SmiteDeluxe
Copy link
Contributor

Is your feature request related to a problem?

Unintuitive that:

  • No row right clicks
  • Two column plotting by selection while one column by current right clicked column
  • No right clicks on table cells

Desired solution

  • Row right clicks for selections
  • Submenus in column right click:
    • "Plot Selection" if one or two selected => plot from selected columns
    • "Plot Column" that plots one column plots on current right clicked columns
  • "Plot Selection" also possible if right click on cells

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels May 26, 2024
@SmiteDeluxe SmiteDeluxe self-assigned this May 26, 2024
@lars-reimann
Copy link
Member

It might also be helpful to show the two-column plots if only one column is selected, e.g. as "x-column of scatterplot". Then the dialog for plot generation opens with the plot and x-column prefilled and the user must only pick a y-column.

@SmiteDeluxe
Copy link
Contributor Author

@lars-reimann not implementing above for now because of additional work it would need. But I do show tooltips to let users know what they have to do to plot

lars-reimann added a commit that referenced this issue Jun 24, 2024
Closes #1180 

### Summary of Changes
(Includes History PR changes)

- Submenus in column right click:
- "From Selection" if one or two selected => plot from selected columns
or hide from selection
- "From Click" that plots one column plots on current right clicked
columns and hides column
- "From Selection" also possible if right click on cells
- All plotting now checks for column type where only numerical is
allowed and shows greyed out with tooltip incl. reason if not possible
- Right clicks if preventClicks is true only allowed if on same element
type, so can change position of same right click by doing it again
- With hiding mult cols from selection the toggleHideColumn method now
takes array and only does it if all columns have same hidden state; for
now adds separate history entries as creating a new action type for this
would be too much

---------

Co-authored-by: Lars Reimann <mail@larsreimann.com>
lars-reimann pushed a commit that referenced this issue Sep 25, 2024
## [0.18.0](v0.17.0...v0.18.0) (2024-09-25)

### Features

* eda history basic setup ([#1212](#1212)) ([597672b](597672b)), closes [#1211](#1211)
* eda refresh outdated view ([#1215](#1215)) ([2295d80](2295d80)), closes [#1214](#1214)
* **eda:** filter by column ([#1217](#1217)) ([77ad26c](77ad26c)), closes [#1216](#1216)
* integrate version 0.28.0 of the `safe-ds` Python library ([#1237](#1237)) ([1b742e7](1b742e7))
* select path for runner when installing ([#1238](#1238)) ([3d9d4db](3d9d4db)), closes [#1144](#1144)

### Bug Fixes

* eda table right click improvements ([#1213](#1213)) ([cf440e3](cf440e3)), closes [#1180](#1180)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants