Allow to use Sylius from 1.7 to 1.10 and php 7.4 and 8.0 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=============================================
+ Coverage 9.51% 26.55% +17.03%
- Complexity 360 399 +39
=============================================
Files 63 77 +14
Lines 1166 1303 +137
=============================================
+ Hits 111 346 +235
+ Misses 1055 957 -98
Continue to review full report at Codecov.
|
loevgaard
requested changes
Aug 24, 2021
| @@ -28,13 +28,13 @@ | |||
| <service id="setono_sylius_gift_card.controller.action.gift_card_balance" | |||
| class="Setono\SyliusGiftCardPlugin\Controller\Action\GiftCardBalanceAction"> | |||
| <argument type="service" id="setono_sylius_gift_card.repository.gift_card"/> | |||
| <argument type="service" id="fos_rest.view_handler.default"/> | |||
| <argument type="service" id="twig"/> | |||
There was a problem hiding this comment.
When we release we need to keep in mind that this is a BC break
loevgaard
requested changes
Aug 24, 2021
Remove Assert in Extension and use @var
loevgaard
reviewed
Aug 25, 2021
loevgaard
reviewed
Aug 25, 2021
loevgaard
reviewed
Aug 25, 2021
loevgaard
approved these changes
Aug 26, 2021
Export Download gift card PDF to API + tests
This was referenced Aug 27, 2021
Expose Customer GiftCards in shop
Expose Gift card balance
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
Co-authored-by: Joachim Løvgaard <joachim@loevgaard.dk>
…e-add-gc-to-order
Expose Add/Remove GC to/from order
Add first Behat scenario for API
update template according to latest changes in sylius
Allow to create Product GC from API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.