Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2234 FN: primary constructors for records, classes and structs #8071

Closed
antonioaversa opened this issue Sep 25, 2023 · 0 comments · Fixed by #8238
Closed

Fix S2234 FN: primary constructors for records, classes and structs #8071

antonioaversa opened this issue Sep 25, 2023 · 0 comments · Fixed by #8238
Assignees
@martin-strecker-sonarsource
Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Milestone
9.13

Comments

@antonioaversa
Copy link
Contributor

antonioaversa commented Sep 25, 2023 •
edited by martin-strecker-sonarsource
Loading

S2234

class Base(int a, int b)
{
    Base(int a, int b, int c) : this(b, a) { }  // FN: primary ctor params inverted
}

class Derived(int a, int b) : Base(b, a);       // FN: ctor params inverted

Related issues:
@antonioaversa antonioaversa added Type: False Negative Rule is NOT triggered when it should be. Area: C#12 C#12 related issues labels Sep 25, 2023
@antonioaversa antonioaversa changed the title Fix S2234 FN: Primary constructors Fix S2234 FN: Primary constructors for records, classes and structs Sep 25, 2023
@antonioaversa antonioaversa mentioned this issue Sep 26, 2023
Open
antonioaversa added a commit that referenced this issue Sep 26, 2023
@antonioaversa
Add repro for #8070, #8071, #8072
d05385a
@antonioaversa antonioaversa mentioned this issue Sep 26, 2023
Merged
@antonioaversa antonioaversa changed the title Fix S2234 FN: Primary constructors for records, classes and structs Fix S2234 FN: primary constructors for records, classes and structs Sep 26, 2023
Merged
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 9.13 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Projects
None yet
Milestone
9.13
Development

Successfully merging a pull request may close this issue.

Fix S2234 FN: primary constructors for records, classes and structs SonarSource/sonar-dotnet
4 participants
@antonioaversa @andrei-epure-sonarsource @martin-strecker-sonarsource @cristian-ambrosini-sonarsource