.NET 8 and C# 12: add repros and UTs for rules starting with P in SonarWay

[antonioaversa]

Rules affected by .NET 8 and C# 12 for rules starting with P in SonarWay.

Adds repros:

• Fix S2234 FN: this and base constructors #8070
• Fix S2234 FN: primary constructors for records, classes and structs #8071
• Fix S2234 FN: lambdas #8072
• Fix S2368 FN: constructors #8083
• Fix S2368 FN: inline arrays #8100
• Fix S4275 FN: primary constructors #8101

Adds UTs with .NET 8 and C# 12 features for:

• S4456
• S4428
• S3926

Rule ideas and improvement tasks created:

• New Rule Idea: Primary constructor parameters only used as local variables in methods should become local variables #8076
• Fix S2292 FN: Support primary constructor parameters #8078

[csaba-sagi-sonarsource]

There is a FN for the following case for PropertiesAccessCorrectField rule.

public class SomeClass(object y)
{
    object x;
    public object Y
    {
        get { return x; }  // FN
        set { x ??= value; } // FN
    }
}

[csaba-sagi-sonarsource]

I left a few comments. Overall nice findings!

[antonioaversa]

There is a FN for the following case for PropertiesAccessCorrectField rule.

Good catch! I have added the reproducer to this PR and an issue for it: #8101

[csaba-sagi-sonarsource]

I left one more comment. you could try to reference the .NET8 assemblies as I suggested since we already have them on the machine or bump the target framework of the UTs.

[antonioaversa]

@costin-zaharia-sonarsource taking over from @csaba-sagi-sonarsource

Here is the last thread open: #8082 (comment)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[costin-zaharia-sonarsource]

LGTM!