Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect with urlrewrite setup #495

Closed
wants to merge 1 commit into from
Closed

Fix redirect with urlrewrite setup #495

wants to merge 1 commit into from

Conversation

Guria
Copy link

@Guria Guria commented Sep 24, 2014

Redirect must be relative to support running with url rewrite rules

Redirect must be relative to support running with url rewrite rules
@mnaberez mnaberez added the web label Sep 24, 2014
@mnaberez
Copy link
Member

Thanks for the pull request but I have decided not to merge it at this time. As far as I can tell, we've never advertised that the web interface will work in a URL rewrite setup. I'd rather not make this change because once we say we support it, we can't easily take that away. The web interface could use some improvement, but supporting it on any arbitrary URL will make that development more difficult.

@mnaberez mnaberez closed this Feb 17, 2015
@Guria
Copy link
Author

Guria commented Feb 17, 2015

It is not about url rewrite support. Not all environments provide ability to run any tools on any port you want (NAT). So there is only 2 options to use web-uis for tools: subdomains (I'm afraid not supported in such environments as well) and placing them on "subfolder" of main site. You should not expect that web-ui always placed under the root of site.

@mnaberez
Copy link
Member

It is not about url rewrite support.

Sorry, I was confused by both the title and description of the patch then.

It looks like there is an open to-do item for this already.

@Guria
Copy link
Author

Guria commented Feb 17, 2015

Url rewrite is just technic used to place one web-app in sub-path of domain. Sorry, I had to provide more detailed explanation in PR.

@mnaberez
Copy link
Member

There's now two proposed solutions (#28 and this one). I've reopened #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants