Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce base_path for web interface #593

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

calvin
Copy link

@calvin calvin commented Mar 19, 2015

This is a pull request to resolve issue #29 and #372.
Instead of relying on HTTP_REFERER like in #28, I have introduced a new option.

This PR also addresses issue #495 (dup: #251).

Implment on existing :class:`supervisor_af_inet_http_server` class,
hence :mod:`medusa` module is remained untouched.
@calvin calvin changed the title Url prefix for web interface Introduce base_path for web interface Mar 19, 2015
@mnaberez mnaberez added the web label Mar 19, 2015
@SEJeff
Copy link

SEJeff commented Mar 31, 2015

@calvin would you mind clearing up the merge conflicts? I'm keen to use this same feature.

… into url-prefix-for-web-interface

Conflicts:
	CHANGES.txt
@calvin
Copy link
Author

calvin commented Apr 1, 2015

@SEJeff resolved the merge conflicts with master branch HEAD.

@@ -48,3 +48,5 @@ Contributors
- Márk Sági-Kazár, 2013-12-16

- Gülşah Köse, 2014-07-17

- Seyeong Jeong, 2016-03-19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it will take a year to accept yor PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this date.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected year in commit fdbdaaf.

@Guria
Copy link

Guria commented Apr 7, 2015

Is there any reason not to use just absolute path?

@lukad
Copy link

lukad commented Apr 13, 2015

👍

server_url = form['SERVER_URL']
location = server_url + '?message=%s' % urllib.quote(
message)
location = '%s?message=%s' % (self.base_path, urllib.quote(message))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine but it should be noted that this PR quietly removed SERVER_URL from the redirect.

Fixed incorrect year.
@thibaultmeyer
Copy link

It is a base feature to working with reverse proxy without creating useless subdomain, do you think it will take a few more years for this PR to be accepted?

@razvanphp
Copy link

Indeed, this will be merged next year and then we will have to wait 2 more years for version v4 to be launched and get into repos, instead of hotfixing one line of code in v3 (#845)

@mwansinck
Copy link

Any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

8 participants