Fix reverse proxy message redirect after web action #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change allows supervisor HTTP server to be served behind a reverse proxy like nginx by fixing the redirect (the only one in web.py).
This is temporary until version 4.0 is launched with the configurable
base_path
(#593), given the release cycles are so big & there are so much left to do for the python 3 release.This works very well behind nginx HTTPS offloading without any hack in the configuration:
I know you already refused this once in PR #495, but I would kindly ask you to reconsider this, it's not breaking anything, there are already only relative links in the whole web interface, so I can't see why this one should not be. This way you actually don't need any
base_path
anymore.Related to #29, #827, makes #669 redundant.