[ASCellNodeVisibilityEvent] Add a new event when scrolling stops #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycsh017
approved these changes
Jul 25, 2023
We have `ASCellNodeVisibilityEvent` events that roughly correlate to the scrollViewDid… delegate methods in UIScrollView. With the current events we get a callback when a user stops dragging a cell, but if the cell decelerates we do not get an event when it comes to a rest. I’ve added `ASCellNodeVisibilityEventDidStopScrolling` to have both `ASTableView` and `ASCollectionView` send this event to the cells in `_cellsForVisibilityUpdates` in `- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView`. I created unit tests to ensure that the proper events are being called for the proper scroll delegate methods.
andrey-golovin-ios
added a commit
to andrey-golovin-ios/Texture
that referenced
this pull request
Oct 5, 2023
* 'master' of https://github.com/TextureGroup/Texture: Fix build errors and a crash in xcode 15 (TextureGroup#2093) [ASCellNodeVisibilityEvent] Add a new event when scrolling stops (TextureGroup#2084) Trying to get CI to work (TextureGroup#2085) fix typo: ASStackLayoutElement.h (TextureGroup#2067) Docs: Fix references of ASViewController/ASNavigationController (non-existent) to ASDKViewController/ASDKNavigationController (TextureGroup#2072) [ASTextKitRenderer] Adding locking when accessing the text renderer cache (TextureGroup#2075) Switch UITextWritingDirection to NSWritingDirection (TextureGroup#2071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
ASCellNodeVisibilityEventevents that roughly correlate to the scrollViewDid… delegate methods in UIScrollView. With the current events we get a callback when a user stops dragging a cell, but if the cell decelerates we do not get an event when it comes to a rest. I’ve addedASCellNodeVisibilityEventDidStopScrollingto have bothASTableViewandASCollectionViewsend this event to the cells in_cellsForVisibilityUpdatesin- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView.I created unit tests to ensure that the proper events are being called for the proper scroll delegate methods.