feat(popover): max-width and border-size css properties are added #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratcorlu
reviewed
Mar 15, 2023
muratcorlu
reviewed
Mar 15, 2023
muratcorlu
reviewed
Apr 11, 2023
muratcorlu
reviewed
Apr 11, 2023
muratcorlu
reviewed
Apr 11, 2023
muratcorlu
changed the title
|
@ozkersemih After fixing failing test, I noticed some UI issues regarding to the border size addition comparing to current tooltip design. Also |
muratcorlu
changed the title
muratcorlu
reviewed
May 5, 2023
muratcorlu
approved these changes
May 5, 2023
uglifycss which is used internally by lit-css plugin that we use to minify our styles breaks the code by replacing all 0px values to 0. this was causing problem, and not a safe thing at all. since uglifycss project is not maintained anymore I manually replaced its functionality with clean-css library.
|
Radio Group selected option seems wrong:
And I didn't understand why secondary and tertiary button hovers changed in the UI tests with this implementation, storybook looks ok (unchanged) but in chromatic, hover states look the same as the default state. @muratcorlu @ozkersemih |
buseselvi
approved these changes
May 9, 2023
|
🎉 This PR is included in version 2.1.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
muratcorlu
added a commit
that referenced
this pull request
May 12, 2023
This PR includes the features/fixes for the release of v2.1.0 ## Features * **Switch**: CSS property to set custom color for `off` state (#527) * **Popover**: CSS properties to set `max-width` and `border-size` (#483) ## Fixes * **Dropdown**: Close dropdown when an item is clicked (#533) * **Popover**: Prevent exiting fullscreen with popover close (#551) * **Dialog**: Prevent exiting fullscreen with dialog close (#548) * **Select**: Select item separator is back (#552) * React wrapper types (#532) * Set package type as module (#570) Thanks to our contributors for this version 🚀 : @muratcorlu @ogunb @abugraokkali @AykutSarac @ozkersemih
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
--bl-popover-border-sizeand--bl-popover-max-width0pxvalues to0. This was causing problem about using this value in CSS calc, and not a safe thing at all. Since UglifyCSS project is not maintained anymore I manually replaced its functionality with clean-css library in build script. (I created an issue to replace uglifycss with something better in lit-css plugin as well)Closes #478