fix: fix react wrapper types #532
Merged
+103
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AykutSarac
requested changes
Apr 18, 2023
There was a problem hiding this comment.
At the generated d.ts file ISelectOption interface requires a parameter so we need to pass a default type:
// src/components/select/bl-select.ts
interface ISelectOption<T = string>Another issue is ValueType is not defined here:
// baklava-react.d.ts
export declare const BlSelectOption: React.LazyExoticComponent<ReactWebComponent<BlSelectOptionType<string>, {
onBlSelectOption: EventName<CustomEvent<ValueType | string | null>>;
onBlFocus: EventName<CustomEvent<ValueType | string | null>>;
onBlBlur: EventName<CustomEvent<ValueType | string | null>>;
}>>;
|
I don't like how we fix this typing issue in general, but I think I addressed the points you mentioned. |
AykutSarac
approved these changes
Apr 20, 2023
|
🎉 This PR is included in version 2.1.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
muratcorlu
added a commit
that referenced
this pull request
May 12, 2023
This PR includes the features/fixes for the release of v2.1.0 ## Features * **Switch**: CSS property to set custom color for `off` state (#527) * **Popover**: CSS properties to set `max-width` and `border-size` (#483) ## Fixes * **Dropdown**: Close dropdown when an item is clicked (#533) * **Popover**: Prevent exiting fullscreen with popover close (#551) * **Dialog**: Prevent exiting fullscreen with dialog close (#548) * **Select**: Select item separator is back (#552) * React wrapper types (#532) * Set package type as module (#570) Thanks to our contributors for this version 🚀 : @muratcorlu @ogunb @abugraokkali @AykutSarac @ozkersemih
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing types in React wrappers.