Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(switch): implement off color variable on bl-switch #527

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

ogunb
Copy link
Contributor

@ogunb ogunb commented Apr 13, 2023

  • add --bl-switch-color-on and --bl-switch-color-off variables for switch
  • deprecate --bl-switch-color in favor of --bl-switch-color-on

Fixes #523

depreacate --bl-switch-color in favor of --bl-switch-color-on

523
@ogunb ogunb requested review from muratcorlu and buseselvi April 13, 2023 08:10
@ogunb
Copy link
Contributor Author

ogunb commented Apr 19, 2023

Hey, @buseselvi. Do you have any comments on this?

Copy link
Contributor

@buseselvi buseselvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚀

@muratcorlu muratcorlu merged commit c5d52b8 into next Apr 20, 2023
@muratcorlu muratcorlu deleted the 523-switch-off-color branch April 20, 2023 07:12
@muratcorlu muratcorlu mentioned this pull request May 10, 2023
muratcorlu added a commit that referenced this pull request May 12, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This PR includes the features/fixes for the release of v2.1.0

## Features

* **Switch**: CSS property to set custom color for `off` state (#527)
* **Popover**: CSS properties to set `max-width` and `border-size` (#483)

## Fixes

* **Dropdown**: Close dropdown when an item is clicked (#533) 
* **Popover**: Prevent exiting fullscreen with popover close (#551)
* **Dialog**: Prevent exiting fullscreen with dialog close (#548)
* **Select**: Select item separator is back (#552) 
* React wrapper types (#532) 
* Set package type as module (#570)

Thanks to our contributors for this version 🚀 :

@muratcorlu @ogunb @abugraokkali @AykutSarac @ozkersemih
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I should be able to change off color of the switch component
3 participants