2024.10 Release #165
Merged
2024.10 Release #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h' in the ending message to account for a kerning issue with the emoji and the monospace console font
Correction for console display of ending message
…Jake/Locksmith into fix-esc8-false-negatives
Use placeholder for version in script source
Update issue templates
Fix ESC8 False Negatives
Implements the OutputPath variable that was previously defined. Allows the op to specify a path to store the Locksmith CSV files in. (Defaults to the current working directory.) Also prefixes the CSVs with "Locksmith" and the current timestamp.
Added parameter validation, comments, and consistent formatting in parameters. Replaced four instances of `(Get-Forest)` with one `$Forest = Get-Forest` and `$Forest`. Removed extraneous semicolon.
Define OutputType Suppress PSScriptAnalyzer rule: PSUseSingularNouns.
Define OutputType
Remove author note. (Team effort!) Defined OutputType.
Almost missed a closing bracket.
What's with me and closing brackets today?!
Define OutputType. Suppress PSScriptAnalyzer rule PSUseSingularNouns.
…me-Flag isn't important.
Code quality updates for 2024.9
PSScriptAnalyzer code quality updates
Removed extra space in file name prefix. Removed errormessage in validate script for backwards compatibility.
Implement the OutputPath variable
Improve ESC3 Condition 2 detections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
-OutputPathparameter now worksLocksmith <date/time>for eaier discovery.