Consolidated redis metrics into a single object #19081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Product#4160 - updated header to be ctrl+option/alt+1-5 for header to avoid conflict with os behaviour - updated strike to be ctrl+option/alt+u to avoid view source browser behaviour
fixes GRO-46
closes TryGhost/Product#4160 - updated shortcut handling, this brings the sidebar shortcuts in line
refs TryGhost/Product#4051 - added a "List-Unsubscribe" header to emails, in compliance with the RFC 8058 requirements - Gmail, Apple Mail, Yahoo Mail, and other popular email clients offer an option to unsubscribe in one-click, based on the "List-Unsubscribe" header. Some require an HTTPS endpoint, some a mailto address; both options are provided in the "List-Unsubscribe" header Co-authored-by: Simon Backx <simon@ghost.org> Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
fixes GRO-23 Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com> Co-authored-by: Sag <guptazy@gmail.com>
no issue - Fixed an issue where the ajax_url tag was exceeding the allowed length of tags in Sentry - Fixed the mechanism for deleting the ajax tags when the error is not an ajax error - Removed the isAjaxError tag, since we can use the other ajax tags to filter for ajax errors now
no issue - The standard error message from Ember Data includes post/page ids in the error message - This causes Sentry to treat each instance as a unique issue and results in many duplicate issues for the same error - This change should mask the ids and allow Sentry to group the errors correctly
no issue Began tracking the following metrics when purging the redis cache: 1. cache_reset_scan - total time to scan the keyspace 2. cache_reset_delete - total time to delete all the matching keys 3. cache_reset - total time in ms to reset the cache 4. cache_reset_keys - total number of keys deleted We can reduce the granularity of these alerts to reduce the load on elastic eventually, but for now it would be nice to collect metrics at this granularity so we can optimize the cache purging performance.
fixes TryGhost/DevOps#111 - this allows us to add labels based upon the contents in a smarter way than the previous workflow
refs https://githubnext.com/copilot-for-prs-sunset - unfortunately the technical preview will end in mid December so we need to cleanup the templating var
refs TryGhost/Product#4159 --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at 9e68f4d</samp> This pull request refactors several components in the `admin-x-settings` app to use common hooks from the `@tryghost/admin-x-framework` package, which reduces code duplication and improves consistency. It also updates the `package.json` file and adds unit tests for the `admin-x-framework` package, which improves the formatting, testing, and dependency management. Additionally, it makes some minor changes to the `hooks.ts`, `FrameworkProvider.tsx`, and `.eslintrc.cjs` files in the `admin-x-framework` package, which enhance the public API and the linting configuration.
Co-authored-by: Ryan Feigenbaum <48868107+royalfig@users.noreply.github.com>
Co-authored-by: Daniel Lockyer <daniellockyer@fastmail.com>
Co-authored-by: Daniel Lockyer <hi@daniellockyer.com>
refs TryGhost@c695497 - the previous glob didn't match correctly
refs TryGhost/Product#4140 - added `social-image` image size to our `internalImagesSizes` list with a max-width of 1200 - extracted image utils from `{{img_url}}` helper to a utils file for re-use - updated `getImageDimensions` method that reads image dimensions and modifies the finalised `metaData` object before use to adjust dimensions and associated URLs to match max width of 1200px
fixes GRO-34 fixes GRO-33 This also adds a new way to run all tests with enforced numeric ObjectIDs. These numeric ids cause issues if they are used withing NQL filters. So they surface tiny bugs in our codebase. You can run tests using this option via: NUMERIC_IDS=1 yarn test:e2e Also removed some defensive logic that could be explained by unquoted ids.
refs TryGhost/Product#4152 --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at a28462f</samp> This pull request adds a new admin-x app called `admin-x-demo`, which demonstrates how to use the shared packages `admin-x-framework` and `admin-x-design-system` to create a simple app that renders a button and a modal. It also improves the development workflow, the vite integration, the dependency management, and the type checking for the admin-x apps and packages. It modifies some files in the `admin-x-framework` and `admin-x-design-system` packages to make the modals prop optional, to introduce a new type for the props from the Ember app, to fix the z-index of the modal backdrop, and to use consistent file extensions and module syntax.
) Reverts TryGhost#19031 Browser tests are failing with an unknown cause
refs TryGhost/Arch#101 Refined the cache invalidation logic so that when updating a user, we only invalidate the cache when an attribute of the user that is used on the frontend changes.
refs TryGhost@a93c665 - this project needs to be built before Admin because Admin symlinks/copies the assets
- this should loop over all apps without us having to manually add them to the debug lines
Co-authored-by: Daniel Lockyer <daniellockyer@fastmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## arch-cm #19081 +/- ##
===========================================
- Coverage 72.77% 72.70% -0.07%
===========================================
Files 1251 1254 +3
Lines 72609 72784 +175
Branches 9601 9613 +12
===========================================
+ Hits 52839 52920 +81
- Misses 18990 19082 +92
- Partials 780 782 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.