Preliminary support for Ubuntu 24 and Ubuntu 24 ARM #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into update_python
…into update_python
williamckha
reviewed
Oct 2, 2024
| @@ -39,7 +39,7 @@ If you are not using Windows 11 and would prefer not to upgrade, you can follow | |||
| 3. Now, let's install Ubuntu. | |||
| - Download the WSL2 kernel from [here](https://docs.microsoft.com/en-us/windows/wsl/wsl2-kernel). | |||
| - Open a PowerShell window and run command `wsl --set-default-version 2` to use WSL2 by default. | |||
| - Install Ubuntu 20.04 LTS or Ubuntu 22.04 LTS from the Microsoft Store. | |||
| - Install Ubuntu 20.04 LTS, Ubuntu 22.04 LTS and Ubuntu 24.04 LTS from the Microsoft Store. | |||
| You can use Ubuntu 20.04 LTS and Ubuntu 22.04 LTS inside Windows through Windows Subsystem for Linux, by following [this guide](./getting-started-wsl.md). **Running and developing Thunderbots on Windows is experimental and not officially supported.** | ||
| If you have a X86_64 machine, we support Ubuntu 20.04 LTS, Ubuntu 22.04 LTS and Ubuntu 24.04 LTS. | ||
|
|
||
| If you have a AARCH64 machine, we support Ubuntu 24.04 LTS. |
There was a problem hiding this comment.
should add in brackets (ARM64) because AArch64 is not as recognizable
|
Maybe while you're at it, throw in #2592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Summary of changes:
python stepping to python 3.12 (required to install pyqt6 on ARM devices via the system package, pip install was broken)
updated SSL game controller to latest (for ARM binaries)
updated Tigers Autoref to latest (new game controller also updates several protobuf definitions)
What works:
ARM bazel build works
X86 full_system/thunderscope/jetson compilation works
What doesn't work:
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue