Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated GitHub actions and fix upload artifacts for simulated tests #3331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

williamckha
Copy link
Contributor

Description

  • Update to actions/checkout@v4
  • Update to actions/update-artifact@v4 (v3 will be deprecated this November)
  • Fix incorrect actions/update-artifact path to simulated test proto logs

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@williamckha williamckha added the DevOps For everything related to logistics of code label Oct 2, 2024
@Mr-Anyone
Copy link
Contributor

look good. seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps For everything related to logistics of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants