Show total time in flat profile output #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run profiling |
|
@tamuri this should be quite quick to review as it's just a few lines of changes and is just changing the output options for the profiling script so not affecting any of the model code. |
tamuri
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that joerick/pyinstrument#285 has been merged and made it into recent
pyinstrumentreleases (from version 4.7.0 onwards) , we can switch to showing total time spent in each function (included nested function calls) in the flat profile output added in #1236 rather than time just within the function itself (with the total time being useful for getting a sense of which function calls are dominating runtime, irrespective of call path).