Rollback pyinstrument to v4.5.3 to resolve memory issues in profiling #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts most of changes in #1466 (other than changing some processing options for flat HTML output).
It appears that in
pyinstrumentv4.7 and above we get continual fast growing memory usage during profiling runs, which is causing out of memory issues on GitHub Actions runs. This seems to not have been resolved in the latestpyinstrumentv5.0 as also seeing same pattern of increasing memory there too.Memory usage plots when running
with
pyinstrument==4.3with
pyinstrument==4.7with
pyinstrument==5.0