-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve primary interface #171
Conversation
High-level comment: one of the pain points with The approach employed here in This PR seems to introduce more binary parsing: have measures been put in place to avoid problems with these parsers if/when updates are released, or are the packets parsed expected to "never" be updated? |
Yes, I am very well aware of that, but unfortunately there are features only available in those interfaces. And at least some of them will not be moved to other interface, as for example the controller is only sending script execution feedback on the particular socket connection that has sent the script. The benefit from getting this feature currently outperforms those concerns from my point of view, as many users seem to struggle with sending script code.
This is currently only a draft implementation and no, there's no such thing currently. But it is definitely on the feature list. I plan to do a similar approach as done in the |
Note: The error_code message changed between versions 5.1 and 5.2
a3d5c81
to
9c3d992
Compare
Closing in favor of UniversalRobots/Universal_Robots_Client_Library#26 |
This branch will
I am not sure yet, to which extent all of those things will be tackled in this MR, but it will definitely be a start from which such features could easily be implemented.