Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuexのstoreの呼び出しをリテラル引数からDot記法へ: singing.ts #2213

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

Segu-g
Copy link
Member

@Segu-g Segu-g commented Aug 11, 2024

内容

store内における関数の呼び出しにおいて、dispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。

  • store/singing.ts
    を変更しています。

関連 Issue

スクリーンショット・動画など

その他

dispatch
actions

actions([\s\n]"([A-Z_])",?
actions.$1(

commit
mutations

mutations([\s\n]"([A-Z_])",?
mutations.$1(
の順に置換してその後眼力チェックしています。

@Segu-g Segu-g requested a review from a team as a code owner August 11, 2024 18:00
@Segu-g Segu-g requested review from Hiroshiba and removed request for a team August 11, 2024 18:00
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

変更ありがとうございます!!!

もう後は元のdispatchやcommitを消せば完了・・・?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants