Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuexのstoreの呼び出しをリテラル引数からDot記法へ: components/Talk #2266

Merged
merged 12 commits into from
Sep 11, 2024

Conversation

Segu-g
Copy link
Member

@Segu-g Segu-g commented Sep 10, 2024

内容

components内における関数の呼び出しにおいて、dispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。

  • components/App.vue
  • components/EngineStartupOverlay.vue
  • components/ToolTip.vue
  • components/Talk/AccentPhrase.vue
  • components/Talk/AudioCell.vue
  • components/Talk/AudioDetail.vue
  • components/Talk/munuBarData.vue
  • components/Talk/TalkEditor.vue
  • components/Talk/ToolBar.vue
  • components/Dialog/Dialog.ts
    を対応しています。

Talk内のコンポーネントでAudioInfo.vueだけdispatchが残っていますがこれは型的に複雑であるのに加え、リファクタリングした方が良さそうな箇所があったので、別PRで対応します。

関連 Issue

スクリーンショット・動画など

その他

@Segu-g Segu-g requested a review from a team as a code owner September 10, 2024 20:11
@Segu-g Segu-g requested review from Hiroshiba and removed request for a team September 10, 2024 20:11
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

ありがとうございます!!!
AudioInfo.vueのリファクタリング部分もありがたいです!!
なんかややこしいというか、不明な点とかあれば何でも聞いてください!! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants