-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vuexのstoreの呼び出しをリテラル引数からDot記法へ: components/Talk #2266
Merged
Hiroshiba
merged 12 commits into
VOICEVOX:main
from
Segu-g:feature/dot-notation-components/1
Sep 11, 2024
Merged
vuexのstoreの呼び出しをリテラル引数からDot記法へ: components/Talk #2266
Hiroshiba
merged 12 commits into
VOICEVOX:main
from
Segu-g:feature/dot-notation-components/1
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
ありがとうございます!!!
AudioInfo.vueのリファクタリング部分もありがたいです!!
なんかややこしいというか、不明な点とかあれば何でも聞いてください!! 🙏
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の続きです。
components内における関数の呼び出しにおいて、dispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。
を対応しています。
Talk内のコンポーネントでAudioInfo.vueだけdispatchが残っていますがこれは型的に複雑であるのに加え、リファクタリングした方が良さそうな箇所があったので、別PRで対応します。
関連 Issue
スクリーンショット・動画など
その他