vuexのstoreの呼び出しをリテラル引数からDot記法へ: components/Talk/AudioInfo.vue #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2024
Hiroshiba
reviewed
Oct 28, 2024
src/components/Talk/AudioInfo.vue
Outdated
Comment on lines
344
to
356
| // FIXME: slider.onChangeとhandleParameterChangeでstate変更が２経路になっているので統一する | ||
| type ParameterConfig = { | ||
| label: string; | ||
| sliderProps: Omit<PreviewSliderHelperProps, "onChange">; | ||
| onChange: PreviewSliderHelperProps["onChange"]; | ||
| key: Parameter["key"]; | ||
| }; | ||
| type Parameter = { | ||
| label: string; | ||
| slider: PreviewSliderHelper; | ||
| action: Parameters<typeof store.dispatch>[0]["type"]; | ||
| onChange: PreviewSliderHelperProps["onChange"]; | ||
| key: keyof Omit<Preset, "name" | "morphingInfo">; | ||
| }; |
There was a problem hiding this comment.
この２つ（ParameterConfigとParameter）を分離させた理由はなんでしょうか？ 👀
雰囲気とりあえず型をあわせたって感じかなという印象を受けたので、もし認識合ってそうでしたらそれがわかるようFIXMEコメント足しときたいなーと！
Hiroshiba
reviewed
Oct 28, 2024
Comment on lines
+476
to
+486
| const parameters = computed<Parameter[]>(() => | ||
| parameterConfigs.value.map((parameterConfig) => ({ | ||
| label: parameterConfig.label, | ||
| slider: previewSliderHelper({ | ||
| ...parameterConfig.sliderProps, | ||
| onChange: parameterConfig.onChange, | ||
| }), | ||
| onChange: parameterConfig.onChange, | ||
| key: parameterConfig.key, | ||
| })), | ||
| ); |
There was a problem hiding this comment.
雰囲気これなくせそうな気がしますね！！
でparameterConfigsをparametersに改名して、あとは型を適当に合わせればきれいになりそう。
お忙しければ、なんか合図くれたらよしなにこっちでやっちゃおうと思います！
Hiroshiba
reviewed
Oct 28, 2024
Hiroshiba
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の続きです。
components内における関数の呼び出しにおいて、dispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。
で後回しにしていた
を対応しています。
その都合上、sliderとそれ以外でのonChangeを共通化する変更を行っています。
関連 Issue
スクリーンショット・動画など
その他