Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions CI inspired by travis/appveyor scripts #278

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

bernhardmgruber
Copy link
Collaborator

This PR adds a few CI builds on Github actions that I have put together form a CI file of my own and taking inspiration from the existing travis/appveyor CI scripts.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@bernhardmgruber
Copy link
Collaborator Author

I think we need to decide which compilers we care about: https://github.com/bernhardmgruber/Vc/actions/runs/961463706
VS2019 and ipcx fail the tests because their results diverge from the reference results more ULPs than other compilers. We could fix that, remove those compilers from the CI or just flag those CI jobs as not mandatory for PRs.

@amadio
Copy link
Collaborator

amadio commented Jun 22, 2021

We need to add -fp-model=precise for ICC and related compilers, I think. They are by default a bit too aggressive with unsafe arithmetic/math optimizations.

@bernhardmgruber
Copy link
Collaborator Author

We need to add -fp-model=precise for ICC and related compilers, I think.

Good guess. Vc detects icpc and icc and sets -fp-model source. That could solve icpx.
The Visual Studio 2019 builds are still failing though.

@bernhardmgruber
Copy link
Collaborator Author

I removed the failing CI runs for now and will create a separate PR for them later.

Copy link
Collaborator

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants