Remove appveyor and travis CI #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would vote for supporting only newer versions if this is the only blocker in fully relying on GitHub actions for the CI |
agheata
approved these changes
Jul 7, 2021
|
Well, the current |
|
OK, let's wait a bit for people to comment, and if no strong opinion against, we merge this |
bernhardmgruber
force-pushed
the
remove_old_ci
branch
from
1a5618c
to
5a6bd32
Compare
bernhardmgruber
force-pushed
the
remove_old_ci
branch
from
5a6bd32
to
7cb49ca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the files for the appveyor and travis CI, since they were superseded by GitHub actions in #278.
Removing travis CI is fine I think, because travis is no longer providing a reasonable free CI service.
Appveyor still works and is even providing older versions of Visual Studio than GitHub actions. E.g. VS2015. Do we care about such old versions? If not, we could even consider to move the minimum Visual Studio version to 2017, which is supported in GitHub actions.
This PR depends on #297, which needs to be merged first.