Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release binary for MacOS 10.13 #127

Closed
jfizz opened this issue Apr 19, 2020 · 5 comments · Fixed by #308
Closed

Add release binary for MacOS 10.13 #127

jfizz opened this issue Apr 19, 2020 · 5 comments · Fixed by #308

Comments

@jfizz
Copy link

jfizz commented Apr 19, 2020

When running [WASI_SDK]/bin/clang I get:

dyld: lazy symbol binding failed: Symbol not found: ____chkstk_darwin
  Referenced from: /Users/foo/Web/wasi-sdk-10.0/bin/clang (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ____chkstk_darwin
  Referenced from: /Users/foo/Web/wasi-sdk-10.0/bin/clang (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libSystem.B.dylib

Abort trap: 6

Which appears to be because the binaries are built on MacOS 10.15. I found a similar issue here: nodegui/nodegui#391
@sbc100
Copy link
Member

sbc100 commented Apr 19, 2020

I think the way to fix this is to pass the CMAKE_OSX_DEPLOYMENT_TARGET to cmake.

On the WebAssembly/waterfall build we use -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12. We should probably do that same here.

kildom pushed a commit to kildom/clang-wasi-port that referenced this issue Jul 14, 2021
@sunfishcode
Don't link in libpreopen initialization code when it isn't needed. (W…
70099d4 
…ebAssembly#127)

* Avoid linking in `populate_libpreopen` when it isn't needed.

* Merge adjacent `if`s using `&&`.
@abrown
Copy link
Collaborator

abrown commented Mar 13, 2023

@jfizz, @sbc100: should we keep this open? Or is there an easy fix that can be made to the CMake files?

@sbc100
Copy link
Member

sbc100 commented Mar 13, 2023

Adding -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12 to the Makefile would be an easy fix yes. We should do that.

@abrown
Copy link
Collaborator

abrown commented Mar 13, 2023

I looked into this: #285 added -DCMAKE_OSX_DEPLOYMENT_TARGET=11.0. Is 11.0 good enough? If we need the older version then we might be outside of Apple's support window. From @yamt in that PR:

The version 11.0 is chosen because Apple seems providing support for two previous releases. (As of writing this, the latest is 13.)

@sbc100
Copy link
Member

sbc100 commented Mar 13, 2023

I don't see any downside using -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12. As long as llvm itself can be built with no issue).

@jfizz do you want to send a PR?

abrown added a commit to abrown/wasi-sdk that referenced this issue Mar 15, 2023
@abrown
Downgrade OSX deployment target to 10.12
db52187 
This change switches the MacOS build to target 10.12, an older version
than currently supported. This would close WebAssembly#127. @sbc100 mentions that
this is the setting used by Emscripten and related projects.
@abrown abrown mentioned this issue Mar 15, 2023
Merged
abrown added a commit that referenced this issue Mar 20, 2023
@abrown
Downgrade OSX deployment target to 10.12 (#308)
4293ded 
This change switches the MacOS build to target 10.12, an older version
than currently supported. This would close #127. @sbc100 mentions that
this is the setting used by Emscripten and related projects.
alexcrichton pushed a commit to alexcrichton/wasi-sdk that referenced this issue Apr 5, 2023
@sbc100
Roll wasi-libc to include snapshot1 (WebAssembly#84)
baa9b68 
This brings in the following changes:

f645f49 Update signal macros after upgrade to snapshot1 (WebAssembly#144)
8b3266d github actions: pin checkout action to v1 (WebAssembly#145)
410c660 Use constructor functions for optional init routines. (WebAssembly#142)
fe13053 c header generation updated for reorganized witx ast (WebAssembly#139)
cd74e1d Correct the version of WebAssembly#136 on master (WebAssembly#141)
446cb3f Wasi snapshot preview1 (WebAssembly#140)
54102f0 Ignore rights in libpreopen. (WebAssembly#129)
8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (WebAssembly#138)
cf81683 Optimize `fmin`, `fmax`, etc. (WebAssembly#120)
deb8eae Don't pre-check capabilities in `openat`. (WebAssembly#130)
ca9046d Use consistent style for wasi-libc C source files. (WebAssembly#131)
951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (WebAssembly#133)
5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (WebAssembly#128)
70099d4 Don't link in libpreopen initialization code when it isn't needed. (WebAssembly#127)
ec4549d Temporarily disable the use of `__heap_base`. (WebAssembly#132)
a214f1c Use __heap_base by dlmalloc (WebAssembly#114)
a94d2d0 Avoid varargs conventions when calling open (WebAssembly#126)
7fcc4f2 Revamp and simplify the libpreopen code. (WebAssembly#110)
eb7230c Remove more unsupported headers. (WebAssembly#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade OSX deployment target to 10.12 abrown/wasi-sdk
3 participants
@sbc100 @abrown @jfizz