Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test signals #140

Merged
merged 7 commits into from
Jun 3, 2020
Merged

Test signals #140

merged 7 commits into from
Jun 3, 2020

Conversation

sunfishcode
Copy link
Member

This adds some basic tests for signal.h functionality added in WebAssembly/wasi-libc#183

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

tests/general/sigabrt.c Outdated Show resolved Hide resolved
tests/general/signals.c Outdated Show resolved Hide resolved
@pchickey pchickey mentioned this pull request Jun 2, 2020
@sunfishcode
Copy link
Member Author

The CI failure is due to needing a newer wasi-libc; cc #141.

@pchickey
Copy link
Collaborator

pchickey commented Jun 3, 2020

merged with master, once this passes CI we will merge and tag release 11

@sunfishcode
Copy link
Member Author

CI passed.

@sunfishcode sunfishcode merged commit ceabbfe into master Jun 3, 2020
@sunfishcode sunfishcode deleted the test-signals branch June 3, 2020 22:04
@pchickey
Copy link
Collaborator

pchickey commented Jun 3, 2020

the built artifacts from here pass lucet's test suite as well, so we're set to go. I'll pushed the tag, we'll let CI build us the release artifacts now.

kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
* Make __wasi_linkcount_t a uint64_t (WebAssembly#134)

Refs: WebAssembly/WASI#127

* Generate the WASI interface from witx.

This replaces the hand-maintained <wasi/core.h> header with a
<wasi/api.h> generated from witx.

Most of the churn here is caused by upstream WASI renamings; hopefully
in the future ABI updates will be less noisy.
kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
This should probably have been part of WebAssembly#140 but we don't actually
support signals so this doesn't get much testing I imagine.

The old names like `__WASI_SIGBUS` no longer exist and the new names
look like `__WASI_SIGNAL_BUS`.
alexcrichton pushed a commit to alexcrichton/wasi-sdk that referenced this pull request Apr 5, 2023
This brings in the following changes:

f645f49 Update signal macros after upgrade to snapshot1 (WebAssembly#144)
8b3266d github actions: pin checkout action to v1 (WebAssembly#145)
410c660 Use constructor functions for optional init routines. (WebAssembly#142)
fe13053 c header generation updated for reorganized witx ast (WebAssembly#139)
cd74e1d Correct the version of WebAssembly#136 on master (WebAssembly#141)
446cb3f Wasi snapshot preview1 (WebAssembly#140)
54102f0 Ignore rights in libpreopen. (WebAssembly#129)
8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (WebAssembly#138)
cf81683 Optimize `fmin`, `fmax`, etc. (WebAssembly#120)
deb8eae Don't pre-check capabilities in `openat`. (WebAssembly#130)
ca9046d Use consistent style for wasi-libc C source files. (WebAssembly#131)
951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (WebAssembly#133)
5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (WebAssembly#128)
70099d4 Don't link in libpreopen initialization code when it isn't needed. (WebAssembly#127)
ec4549d Temporarily disable the use of `__heap_base`. (WebAssembly#132)
a214f1c Use __heap_base by dlmalloc (WebAssembly#114)
a94d2d0 Avoid varargs conventions when calling open (WebAssembly#126)
7fcc4f2 Revamp and simplify the libpreopen code. (WebAssembly#110)
eb7230c Remove more unsupported headers. (WebAssembly#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants