Updated expected results #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were generated using latest wasmtime release (0.16.0) and the wasi-sdk 10 release binaries.
|
Are these differences to be expected @sunfishcode ? |
|
I'm also seeing a failure in the stat.c tests (seems like lstat is failing): |
|
For the trap messages, Wasmtime recently changed its output to format the backtrace offsets differently. The change you have here is fine for now, though of course it'd be good to find a more general way of handling this too. For the destructor changes, the change here is incorrect. The difference is due to a bug that this patch fixes, and that fix isn't in the 10.x release branch. We probably need to disable that test when running with clang <= 10. The stat.c failure appears to be a recent regression in Wasmtime. We're investigating. |
Closed
kildom
pushed a commit
to kildom/clang-wasi-port
that referenced
this pull request
Jul 14, 2021
* Make __wasi_linkcount_t a uint64_t (WebAssembly#134) Refs: WebAssembly/WASI#127 * Generate the WASI interface from witx. This replaces the hand-maintained <wasi/core.h> header with a <wasi/api.h> generated from witx. Most of the churn here is caused by upstream WASI renamings; hopefully in the future ABI updates will be less noisy.
|
This is outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were generated using latest wasmtime release (0.16.0) and the
wasi-sdk 10 release binaries.