Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick PR's for WordPress 5.4 beta 2 #20275

Merged
merged 10 commits into from
Feb 17, 2020
Merged

Cherry Pick PR's for WordPress 5.4 beta 2 #20275

merged 10 commits into from
Feb 17, 2020

Commits on Feb 17, 2020

  1. Block Library: Columns: Fix equal column growth for unassigned-width … 

    …columns (#20169)

* Block Library: Columns: Fix equal column growth for unassigned-width columns

* Block Library: Columns: Restore mid-range viewport styles

* Block Library: Columns: Keep margin resets in mid-range viewports

Reference from prior to #19515 : https://github.com/WordPress/gutenberg/blob/7997bf66490bab0f6984a114c22ad125f04b9e89/packages/block-library/src/columns/editor.scss#L69-L75

* Block Library: Columns: Update comment to reference mid-range 2 columns
    @aduth @jorgefilipecosta
    aduth authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    6594eab View commit details
    Browse the repository at this point in the history

  2. Fix missing i18n in custom gradient picker (#20184)

    @pedro-mendonca @jorgefilipecosta
    pedro-mendonca authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b633a7d View commit details
    Browse the repository at this point in the history

  3. Use className prop instead of hard-coded className (#20164)

    @talldan @jorgefilipecosta
    talldan authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    80f5df3 View commit details
    Browse the repository at this point in the history

  4. Format library: link: remove aria-label (#18742) 

    * Format library: link: remove aria-label

* Adjust new e2e snap
    @ellatrix @jorgefilipecosta
    ellatrix authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    62c94ce View commit details
    Browse the repository at this point in the history

  5. Edit-site Package: Make public, set version to 1.3.0-alpha.0 (#20210) 

    This hasn't been published to npm yet. We're interested in using it to explore Full Site Editing outside of a 'regular' Gutenberg context, so we'd like to publish it.

Note that even though the package hasn't been published yet, the version number has been regularly bumped by the publish script, and it's now at 1.2.0. I'd like to set it to an alpha version (to make clear that it's still in its early stages and not yet ready for production). I've thus chosen 1.3.0-alpha.0 -- I hope that choice is okay.
    @ockham @jorgefilipecosta
    ockham authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    786cb6a View commit details
    Browse the repository at this point in the history

  6. Fix: Conditionaly apply Editor Skeleton html element styles (#20245)

    @jorgefilipecosta
    jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b361998 View commit details
    Browse the repository at this point in the history

  7. 17642 adds edit state to frames to fix new tab issue (#17641) 

    * adds edit state to frames to fix new tab issue

* moves default state build into else of gallery condition and adds gallery toolbar logic to reach parity with Core.

* fixes selection object reference to proper state

* improves and adds documentation

* removes buildAndSetEditFrame as it should be added in core and not here. Also removes the declaration of the button text as the default already is 'select'

* truly removes editState fu function

* fixes linting issues

* Adjusts PR to factor in review suggestions
    @anthonyburchell @jorgefilipecosta
    anthonyburchell authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    4840699 View commit details
    Browse the repository at this point in the history

  8. Fix: Inline image width pop-up 'wanders' down page (#20232)

    @jorgefilipecosta
    jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    2fbfbf9 View commit details
    Browse the repository at this point in the history

  9. Fix: Color formatter appears when color choosing is not possible

    @jorgefilipecosta
    jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    247f734 View commit details
    Browse the repository at this point in the history

  10. Make label Open in new tab consistent.

    @Soean @jorgefilipecosta
    Soean authored and jorgefilipecosta committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    5cd48b6 View commit details
    Browse the repository at this point in the history