[Mobile] List V2 - Fixes split issues #43949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +88 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
geriux
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
SiobhyB
requested changes
Sep 7, 2022
There was a problem hiding this comment.
@geriux, I see that the E2E tests are consistently failing with the following error:
Error: /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/__snapshots__/Group-can-be-created-using-the-slash-inserter-1-chromium.txt is missing in snapshots.
I see that that file was merged in #42801, two days before #42780 was merged. Do you think cherry picking that commit may resolve the errors?
SiobhyB
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Works perfectly for me in testing on Android and iOS, thank you @geriux! 🙇♀️
The code also makes sense to me and didn't leave me with any questions. The only thing, mentioned here, is that the E2E tests are failing consistently. I think this might be resolved by cherry picking #42801?
Approving as I don't want to hold anything up and I don't see any other blockers. :)
Nice catch! I've cherry-picked that change, it runs now locally so let's wait for CI 🤞
Thank you so much for reviewing and testing! 🙇 |
|
There's another failing E2E related to #42947 I'm just gonna merge this so we can continue with the beta fix. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43873
What?
This PR fixes some split issues like trying to split a List (V2) in the middle or merging a Paragraph block and a List Item block.
Why?
To have the same functionality as the web editor and the previous version of the List.
How?
It adds a native variant of the
useEnterhook modified for native, on the web editor it uses listeners for theonKeyPresswhere it also can stop other events to trigger in some specific scenarios so we couldn't have the same functionality on native.So on native we are now passing an
onEnterprop to theRichTextcomponent where we can handle the customonSplitfunctionality for the List block.It also cherry-picks #42780 as it is needed to be able to merge for example a Paragraph block with a List Item block.
Testing Instructions
Returnkey twice.Backspacekey.Screenshots or screencast
iOSBefore.mov
iOSAfter.mov
AndroidBefore.mov
AndroidAfter.mov