Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.82.1 #5140

Merged
merged 11 commits into from
Sep 8, 2022
Merged

Release 1.82.1 #5140

merged 11 commits into from
Sep 8, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Sep 6, 2022

Release for Gutenberg Mobile 1.82.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Fixes some split issues like trying to split a List (v2) in the middle or merging a Paragraph block with a List Item block.

Change 2

Prevents an error when pasting an empty List v2 block.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@SiobhyB SiobhyB marked this pull request as ready for review September 8, 2022 11:01
@SiobhyB SiobhyB requested a review from geriux September 8, 2022 11:01
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Sep 8, 2022

🟢 Writing Flow checklist (Android)

Build: wordpress-installable-build-pr17135-d1d3dc1.apk
Device: Pixel 6 (Android 13)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

🟢 New changes (Android)

Build: wordpress-installable-build-pr17135-d1d3dc1.apk
Device: Pixel 6 (Android 13)

@geriux
Copy link
Contributor

geriux commented Sep 8, 2022

🟢 Writing Flow checklist (iOS)

Build: pr19290-7d2af83
Device: iPhone 13 Pro (OS 16)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block
    • ⚠️ Merging two lists doesn't work as with List V1, this is reproducible on the web editor as well. We might need to update the test case.

Undo / Redo - Test Cases

@geriux
Copy link
Contributor

geriux commented Sep 8, 2022

@geriux
Copy link
Contributor

geriux commented Sep 8, 2022

Hey @SiobhyB 👋 what do you think if we also add this change in the PR description? Since we are bringing it from the previous hotfix release, thought we might as well test it.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Sep 8, 2022

@geriux, good idea! I've gone ahead to update the description now. Do you think this should be included in the release notes too?

@geriux
Copy link
Contributor

geriux commented Sep 8, 2022

@geriux, good idea! I've gone ahead to update the description now. Do you think this should be included in the release notes too?

I don't think so, since it is in the 1.81.2 release. Thanks for updating the description!

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@SiobhyB SiobhyB enabled auto-merge September 8, 2022 17:27
@SiobhyB SiobhyB merged commit ea25e4a into trunk Sep 8, 2022
@SiobhyB SiobhyB deleted the release/1.82.1 branch September 8, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants