Mobile Release v1.82.1 #43906
Merged
Mobile Release v1.82.1 #43906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mobile - Introduce BlockListCompact - Lighter version of the default BlockList with simpler functionality for use cases like the List V2 block * Mobile - Update List V2 tests since it's not needed to fire the layout event change with the BlockListCompact component * Mobile - BlockListCompact - Add note of the component props and which block is currently using it
…ems (#43244) * List block v2: use default color for preferred color scheme * Use usePreferredColorSchemeStyle hook for List Item style * Remove unneeded font-size value from list item styles
* Mobile - Fix dynamic React Native version * Mobile - Adds jvmargs setting
…43353) * Use default placeholder text color for native List Item * Move list item placeholder hex value to stylesheet * Resolve test failure * Add opacity to list block placeholder color styles * Update List block v2 placholder currentTextColor * Mobile - List Item - Check if currentTextColor is not undefined and moves opacity value into a const * Mobile - List Item - Add optional chaining for style.color Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
* Set tintColor on action sheets for iOS * [Code quality] Replace hex codes with CSS * [Code quality] Refine 'buttonTitleColor' const * Refactor code to use 'usePreferredColorScheme' 'usePreferredColorScheme' is used instead of 'usePreferredColorSchemeStyle' as only a hex code needs to be passed as a tintColor. * Refactor to workaround test failures The UI tests in Gutenberg Mobile were failing as 'styles' returns 'undefined' (in the tests) when called from the 'PickerComponent' function. Example: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/18255/workflows/16df0260-7972-465b-b400-ec37603dfd9e/jobs/100060 This commit seeks to workaround that error by only calling the internal styles from the main Picker class. Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
SiobhyB
added
the
Mobile App - i.e. Android or iOS
4 tasks
* Mobile - List V2 - Add useEnter to fix splitting issue * Merging blocks: allow x to be merged into wrapper blocks (quote, list, group...) (#42780) * Add test for the group block (#42801) Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Justin Ahinon <justiny.ahinon@gmail.com>
SiobhyB
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ellatrix
reviewed
Oct 5, 2023
| ); | ||
| const onReplaceList = useCallback( | ||
| ( blocks, ...args ) => { | ||
| if ( ! preventDefault.current ) { |
There was a problem hiding this comment.
What does this do? Why is it different from web?
There was a problem hiding this comment.
What does this do? Why is it different from web?
We have a different logic when handling "Enter" events on native for RichText components, I remember we had to diverge with our own useEnter hook to allow splitting Lists in the middle. I can check the code further to provide more information since we introduced this a little over a year ago.
Is there something that's affecting this code @ellatrix or is it just have more context on this different behavior? Let us know if you want more information about it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.82.1 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5140