Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

SHA fetching can be very slow if conflict checking is happening #82

Closed
rschlaikjer opened this issue Aug 15, 2014 · 1 comment
Closed

SHA fetching can be very slow if conflict checking is happening #82

rschlaikjer opened this issue Aug 15, 2014 · 1 comment

Comments

@rschlaikjer
Copy link
Contributor

SHAs were getting set very slowly since they could be stuck behind conflict checking jobs in the GitQueue. This is caused problems where two verify jobs end up both running after an edit, which would raise a GitError, as well as the issue of external resources reliant on pickme SHA not being usable.
ymilki added a commit that referenced this issue Aug 18, 2014
@ymilki
Release 0.3.3
33a6c84 
 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this issue Aug 18, 2014
@ymilki
Release 0.3.3
67aa4d6 
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this issue Aug 18, 2014
@ymilki
Release 0.3.3
f41a274 
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
@ymilki ymilki mentioned this issue Aug 18, 2014
Merged
ymilki added a commit that referenced this issue Aug 18, 2014
@ymilki
Release 0.3.3
539518f 
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this issue Aug 18, 2014
@ymilki
Merge pull request #93 from Yelp/release-candidate
cc1016a 
Release 0.3.3

 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
@rschlaikjer
Copy link
Contributor Author

Fixed in release 0.3.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rschlaikjer