Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Add rerun detection button #92

Merged
merged 2 commits into from
Aug 18, 2014
Merged

Add rerun detection button #92

merged 2 commits into from
Aug 18, 2014

Conversation

rschlaikjer
Copy link
Contributor

Add a button to the pushmaster UI for pushes that will kick off conflict detection again for all the pickmes in the push. This would be useful for rechecking the push against a previous push that has just certed.

@ymilki
Copy link
Member

ymilki commented Aug 18, 2014

This looks ok for now. We could probably figure out some way to prevent rerunning merge conflct detection if master hasn't changed. But this is good enough.

ymilki added a commit that referenced this pull request Aug 18, 2014
Add rerun detection button

Allow pushmasters to manually trigger merge-detection. Useful when a previous push has certed.
@ymilki ymilki merged commit 645dd1b into Yelp:master Aug 18, 2014
ymilki added a commit that referenced this pull request Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this pull request Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
@ymilki ymilki mentioned this pull request Aug 18, 2014
ymilki added a commit that referenced this pull request Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this pull request Aug 18, 2014
Release 0.3.3

 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants