Gowin. Add PLL pads. #1309
Merged
Gowin. Add PLL pads. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CLKIN input of the PLL is connected to a special pin, then it makes sense to try to place the PLL so that it uses a direct implicit non-switched connection to this pin. The transfer of information about pins for various purposes has been implemented (clock input signal, feedback, etc), but so far only CLKIN is used. Signed-off-by: YRabbit <rabbit@yrabbit.cyou>
gatecat
reviewed
Apr 8, 2024
| if (ci.bel == BelId()) { | ||
| NetInfo *ni = ci.getPort(id_CLKIN); | ||
| if (ni && ni->driver.cell) { | ||
| BelId pll_bel = gwu.get_pll_bel(ni->driver.cell->bel, id_CLKIN_T); |
There was a problem hiding this comment.
I think this code will fail in the get_pll_bel call if the driver is unplaced - say logic, or another PLL, or whatever - the test should probably be ni && ni->driver.cell && ni->driver.cell->bel != BelId()
There was a problem hiding this comment.
oh yes, you're right.
Do not search for pads if the signal source for the PLL is something other than the IO pin - these are guaranteed to already be placed and have a bound Bel. Signed-off-by: YRabbit <rabbit@yrabbit.cyou>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CLKIN input of the PLL is connected to a special pin, then it makes sense to try to place the PLL so that it uses a direct implicit non-switched connection to this pin.
The transfer of information about pins for various purposes has been implemented (clock input signal, feedback, etc), but so far only CLKIN is used.