Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Himbaechel xilinx : XDC improvements #1375

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

marzoul
Copy link
Contributor

@marzoul marzoul commented Oct 1, 2024

Hi,

This pull request brings several improvements to ease the life of users.

  • fix crashes
  • more messages about unsupported or invalid constraints
  • support multiple nets per command
  • get_nets tries lowercase as fallback to have consistent behavior with vivado in case of designs originally in VHDL

Regards,
Adrien

@@ -213,7 +213,9 @@ struct BaseCtx

NetInfo *getNetByAlias(IdString alias) const
{
return nets.count(alias) ? nets.at(alias).get() : nets.at(net_aliases.at(alias)).get();
if(nets.count(alias) > 0) return nets.at(alias).get();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run a make clangformat on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now done.

@gatecat gatecat merged commit b3b2392 into YosysHQ:master Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants