Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import and test against Sinsemilla test vectors from zcash-hackworks #2079

Closed
Tracked by #2266
dconnolly opened this issue Apr 27, 2021 · 1 comment · Fixed by #2445
Closed
Tracked by #2266

Import and test against Sinsemilla test vectors from zcash-hackworks #2079

dconnolly opened this issue Apr 27, 2021 · 1 comment · Fixed by #2445
Assignees
@dconnolly
Labels
A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 14

Comments

@dconnolly
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We've added Sinsemilla-based commitments for Orchard, and want to make sure they are compatible with the code being used in zcashd and the https://github.com/zcash-hackworks/zcash-test-vectors/ implementation.

Describe the solution you'd like
Render out the test vectors in zcash/zcash-test-vectors#17 as Rust-compatible, import into zebra-chain, and ensure our old/new tests pass against them.
@dconnolly dconnolly added A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks labels Apr 27, 2021
@dconnolly dconnolly self-assigned this Apr 27, 2021
This was referenced Apr 27, 2021
Closed
Merged
@mpguerra mpguerra added S-needs-triage Status: A bug report needs triage and removed S-needs-triage Status: A bug report needs triage labels Apr 29, 2021
@teor2345 teor2345 mentioned this issue Jun 9, 2021
Closed
6 tasks
@dconnolly dconnolly mentioned this issue Jun 24, 2021
Merged
2 tasks
@mpguerra
Copy link
Contributor

I see #2384 has merged. Are there any other test vectors that we need to import here or can we close this one?

@dconnolly dconnolly mentioned this issue Jul 5, 2021
Merged
2 tasks
@arya2 arya2 mentioned this issue Mar 31, 2023
Merged
6 tasks
@mpguerra mpguerra mentioned this issue Apr 11, 2023
Closed
4 tasks
mpguerra added a commit that referenced this issue May 19, 2023
@mpguerra
#2079 was fixed by #2445
2be0331
mergify bot pushed a commit that referenced this issue May 23, 2023
@mpguerra @teor2345
Delete outdated TODOs refering to closed issues (#6732)
ec2e9ca 
* ZIPs were updated to remove ambiguity, this was tracked in #1267.

* #2105 was fixed by #3039 and #2379 was closed by #3069

* #2230 was a duplicate of #2231 which was closed by #2511

* #3235 was obsoleted by #2156 which was fixed by #3505

* #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969

* We migrated to Rust 2021 edition in Jan 2022 with #3332

* #1631 was closed as not needed

* #338 was fixed by #3040 and #1162 was fixed by #3067

* #2079 was fixed by #2445

* #4794 was fixed by #6122

* #1678 stopped being an issue

* #3151 was fixed by #3934

* #3204 was closed as not needed

* #1213 was fixed by #4586

* #1774 was closed as not needed

* #4633 was closed as not needed

* Clarify behaviour of difficulty spacing

Co-authored-by: teor <teor@riseup.net>

* Update comment to reflect implemented behaviour

Co-authored-by: teor <teor@riseup.net>

* Update comment to reflect implemented behaviour when retrying block downloads

Co-authored-by: teor <teor@riseup.net>

* Update `TODO` to remove closed issue and clarify when we might want to fix

Co-authored-by: teor <teor@riseup.net>

* Update `TODO` to remove closed issue and clarify what we might want to change in future

Co-authored-by: teor <teor@riseup.net>

* Clarify benefits of how we do block verification

Co-authored-by: teor <teor@riseup.net>

* Fix rustfmt errors

---------

Co-authored-by: teor <teor@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 14
Development

Successfully merging a pull request may close this issue.

Fix Orchard implementation, refactor, and add more test vectors ZcashFoundation/zebra
3 participants
@dconnolly @mpguerra @teor2345