Verify Halo2 proofs as part of V5 transaction verification #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
added
A-consensus
conradoplg
previously requested changes
Nov 9, 2021
There was a problem hiding this comment.
Looks good! There's just a small suggestion.
I'll leave this unapproved to make sure #2645 is merged first.
jvff
previously approved these changes
Nov 10, 2021
dconnolly
force-pushed
the
halo2-verifier
branch
2 times, most recently
from
16b2c2b to
7d8b9ca
Compare
dconnolly
force-pushed
the
halo2-verifier
branch
from
4681f76 to
6607633
Compare
dconnolly
force-pushed
the
verify-halo2
branch
from
e0d9463 to
fa8e145
Compare
teor2345
previously approved these changes
Nov 17, 2021
teor2345
force-pushed
the
verify-halo2
branch
from
fa8e145 to
d6c5cbe
Compare
teor2345
approved these changes
Nov 17, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
* ZIPs were updated to remove ambiguity, this was tracked in #1267. * #2105 was fixed by #3039 and #2379 was closed by #3069 * #2230 was a duplicate of #2231 which was closed by #2511 * #3235 was obsoleted by #2156 which was fixed by #3505 * #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969 * We migrated to Rust 2021 edition in Jan 2022 with #3332 * #1631 was closed as not needed * #338 was fixed by #3040 and #1162 was fixed by #3067 * #2079 was fixed by #2445 * #4794 was fixed by #6122 * #1678 stopped being an issue * #3151 was fixed by #3934 * #3204 was closed as not needed * #1213 was fixed by #4586 * #1774 was closed as not needed * #4633 was closed as not needed * Clarify behaviour of difficulty spacing Co-authored-by: teor <teor@riseup.net> * Update comment to reflect implemented behaviour Co-authored-by: teor <teor@riseup.net> * Update comment to reflect implemented behaviour when retrying block downloads Co-authored-by: teor <teor@riseup.net> * Update `TODO` to remove closed issue and clarify when we might want to fix Co-authored-by: teor <teor@riseup.net> * Update `TODO` to remove closed issue and clarify what we might want to change in future Co-authored-by: teor <teor@riseup.net> * Clarify benefits of how we do block verification Co-authored-by: teor <teor@riseup.net> * Fix rustfmt errors --------- Co-authored-by: teor <teor@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to verify Halo2 proofs for V5 transactions.
Solution
Now that we have an async batch Halo2 verifier service, we can call that from our transaction verifier service.
Our current test vectors do not have V5 transactions with verifiable Halo2 proofs. 👀
Resolves #2105
Review
Anyone can verify.
Our current test vectors do not have V5 transactions with verifiable Halo2 proofs, the halo2 verifier service is currently verifying that it can verify the proofs by themselves, but reviewer can decide if that is sufficient to merge this PR or if we want to block on V5 transactions w/ Halo2 proofs.
Reviewer Checklist