Delete credential flags #774

henriquemoraeszup · 2020-12-14T11:28:34Z

Description

Added flag capacity on delete credential

How to verify it

Run the command rit delete credential --provider=<your provider>

Changelog

Added flag capacity to rit delete credential

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> merge

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/cmd.go # pkg/cmd/delete_credential.go # pkg/cmd/delete_credential_test.go

pkg/cmd/delete_credential.go

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Fixing tests and mocks

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # internal/mocks/mocks.go

codecov-io · 2020-12-15T11:04:59Z

Codecov Report

Merging #774 (ff08f94) into master (e299f0b) will increase coverage by 0.04%.
The diff coverage is 82.97%.

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   83.77%   83.81%   +0.04%     
==========================================
  Files         110      110              
  Lines        3840     3856      +16     
==========================================
+ Hits         3217     3232      +15     
+ Misses        444      443       -1     
- Partials      179      181       +2

Impacted Files	Coverage Δ
pkg/cmd/cmd.go	`68.18% <54.54%> (-13.64%)`	⬇️
pkg/cmd/delete_credential.go	`96.47% <90.90%> (-3.53%)`	⬇️
pkg/cmd/formula.go	`90.82% <100.00%> (+5.11%)`	⬆️
pkg/commands/builder.go	`90.30% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e299f0b...ff08f94. Read the comment docs.

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

pkg/cmd/delete_credential.go

pkg/cmd/cmd.go

kaduartur · 2020-12-15T18:43:59Z

pkg/cmd/delete_credential.go

@@ -12,6 +13,15 @@ import (
 	"github.com/ZupIT/ritchie-cli/pkg/stdin"
 )

+const (
+	providerFlagName        = "provider"


could you extract the flag struct from the formula.go and use addReservedFlags function to generate all flags to any commands?

Sorry I am a bit lost, are core commands supposed to have reserved flags?

pkg/cmd/delete_credential.go

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

kaduartur · 2020-12-22T21:09:58Z

pkg/cmd/delete_credential.go

-		}
-		prompt.Info(fmt.Sprintf("Current env: %s", env))
+func addFlags(flags *pflag.FlagSet) {
+	flags.String(providerFlagName, "", providerFlagDescription)


I think that you can use the flag struct to represent a flag.

ritchie-cli/pkg/cmd/formula.go

Line 78 in 84b0008

type flag struct {

you can use this function to create your flags.

ritchie-cli/pkg/cmd/formula.go

Line 227 in 84b0008

func addReservedFlags(flags *pflag.FlagSet) {

here we have an example of how to use it:

ritchie-cli/pkg/cmd/formula.go

Line 47 in 84b0008

reservedFlags = flags{

you can extract this function and struct to cmd.go file

now I see...

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/formula.go

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

kaduartur

Good job 🚀

kaduartur · 2021-01-04T18:41:00Z

/merge qa

ritchie-bot · 2021-01-04T18:41:05Z

👌 Merged branch hm/delete-credential-flags into qa

kaduartur · 2021-01-04T22:01:38Z

pkg/cmd/delete_credential.go

+		return inputConfig{}, errors.New("you have no defined credentials in this env")
+	}
+
+	providers := make([]string, len(data))


When you declare an array like this, you are saying that its capacity is the data size and you are giving each position of the array an empty value, by appending it will add to the next position displaying to the user a select with empty fields.

For example, if the data has a size of 3 you will have an array with size 3, and when appending it will add one more position and the size of your array will be 6 with the first 3 empty positions.

we have two ways to fix this:

var providers []string // Simpler providers := make([]string, 0, len(data)) // More complex

the first option does not pass the linter since we need to preallocate it, going for the second

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

kaduartur · 2021-01-08T19:04:08Z

/merge qa

ritchie-bot · 2021-01-08T19:04:13Z

👌 Merged branch hm/delete-credential-flags into qa

Improved tests and resolve input logic

20d5d07

henriquemoraeszup requested review from brunasilvazup, kaduartur, lucasdittrichzup, rodrigomedeirosf and victorschumacherzup as code owners December 14, 2020 11:28

Fixing some tests

e23b3c9

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> merge

henriquemoraeszup force-pushed the hm/delete-credential-flags branch from 35c1293 to e23b3c9 Compare December 14, 2020 11:29

Merge branch 'master' of github.com:ZupIT/ritchie-cli into hm/delete-…

02d2d7a

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/cmd.go # pkg/cmd/delete_credential.go # pkg/cmd/delete_credential_test.go

henriquemoraeszup added 🔨 improvement Improvement in features 🚧 WIP Work in Progress labels Dec 14, 2020

This was linked to issues Dec 14, 2020

Support flags for rit delete credential #714

Closed

Tests with Testify in Delete credential #738

Closed

brunasilvazup reviewed Dec 14, 2020

View reviewed changes

pkg/cmd/delete_credential.go Outdated Show resolved Hide resolved

Fixing tests, segregating mocks

0e9de1b

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Fixing tests and mocks

henriquemoraeszup force-pushed the hm/delete-credential-flags branch from d5e8ff4 to 0e9de1b Compare December 14, 2020 17:22

henriquemoraeszup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Dec 14, 2020

brunasilvazup previously approved these changes Dec 14, 2020

View reviewed changes

Fixing provider

24fc74c

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

henriquemoraeszup dismissed brunasilvazup’s stale review via 24fc74c December 14, 2020 17:25

Merge branch 'master' of github.com:ZupIT/ritchie-cli into hm/delete-…

47d5fc2

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # internal/mocks/mocks.go

fixing tests

d87b133

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

brunasilvazup reviewed Dec 15, 2020

View reviewed changes

pkg/cmd/delete_credential.go Outdated Show resolved Hide resolved

brunasilvazup previously approved these changes Dec 15, 2020

View reviewed changes

kaduartur suggested changes Dec 15, 2020

View reviewed changes

henriquemoraeszup added 🚧 WIP Work in Progress and removed ✔️ ready-for-review ready for review 🚧 WIP Work in Progress labels Dec 19, 2020

henriquemoraeszup added the waiting reply Waiting for an answer to a comment label Dec 19, 2020

Review corrections

ccbf9f2

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

henriquemoraeszup dismissed brunasilvazup’s stale review via ccbf9f2 December 19, 2020 17:38

Fixing tests

bdb7fc3

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

henriquemoraeszup self-assigned this Dec 19, 2020

henriquemoraeszup mentioned this pull request Dec 19, 2020

created rit add workspace command #809

Merged

henriquemoraeszup added the ✔️ ready-for-review ready for review label Dec 19, 2020

henriquemoraeszup mentioned this pull request Dec 21, 2020

Tests with Testify in Pkg/Cmd #776

Closed

34 tasks

Extracting flag addition into a method

7c519e3

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

henriquemoraeszup removed the waiting reply Waiting for an answer to a comment label Dec 21, 2020

kaduartur suggested changes Dec 22, 2020

View reviewed changes

henriquemoraeszup added 4 commits December 23, 2020 08:07

Extracting flag struct

d8aeae1

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

linter

8868107

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

Merge branch 'master' of github.com:ZupIT/ritchie-cli into hm/delete-…

f9527a5

…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/formula.go

linter

328d385

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

brunasilvazup previously approved these changes Jan 4, 2021

View reviewed changes

kaduartur approved these changes Jan 4, 2021

View reviewed changes

kaduartur suggested changes Jan 4, 2021

View reviewed changes

Delete credential bug fix

10f9b8e

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

henriquemoraeszup dismissed brunasilvazup’s stale review via 10f9b8e January 7, 2021 13:28

Linter correction

ff08f94

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

kaduartur approved these changes Jan 8, 2021

View reviewed changes

kaduartur merged commit f77fb8d into ZupIT:master Jan 11, 2021

henriquemoraeszup added the 📚 documentation Improvements or additions to documentation label Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete credential flags #774

Delete credential flags #774

henriquemoraeszup commented Dec 14, 2020

codecov-io commented Dec 15, 2020 •

edited

Loading

kaduartur Dec 15, 2020

henriquemoraeszup Dec 19, 2020

kaduartur Dec 22, 2020

henriquemoraeszup Dec 23, 2020

kaduartur left a comment

kaduartur commented Jan 4, 2021

ritchie-bot bot commented Jan 4, 2021

kaduartur Jan 4, 2021 •

edited

Loading

henriquemoraeszup Jan 7, 2021

kaduartur commented Jan 8, 2021

ritchie-bot bot commented Jan 8, 2021

Delete credential flags #774

Delete credential flags #774

Conversation

henriquemoraeszup commented Dec 14, 2020

Description

How to verify it

Changelog

codecov-io commented Dec 15, 2020 • edited Loading

Codecov Report

kaduartur Dec 15, 2020

Choose a reason for hiding this comment

henriquemoraeszup Dec 19, 2020

Choose a reason for hiding this comment

kaduartur Dec 22, 2020

Choose a reason for hiding this comment

henriquemoraeszup Dec 23, 2020

Choose a reason for hiding this comment

kaduartur left a comment

Choose a reason for hiding this comment

kaduartur commented Jan 4, 2021

ritchie-bot bot commented Jan 4, 2021

kaduartur Jan 4, 2021 • edited Loading

Choose a reason for hiding this comment

henriquemoraeszup Jan 7, 2021

Choose a reason for hiding this comment

kaduartur commented Jan 8, 2021

ritchie-bot bot commented Jan 8, 2021

codecov-io commented Dec 15, 2020 •

edited

Loading

kaduartur Jan 4, 2021 •

edited

Loading