Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve term engineer and repair specialist #3186

Closed
thojkooi opened this issue Jan 19, 2016 · 6 comments
Closed

improve term engineer and repair specialist #3186

thojkooi opened this issue Jan 19, 2016 · 6 comments
Labels
kind/documentation kind/task
Milestone
3.10.0

Comments

@thojkooi
Copy link
Contributor

"Repair Specialists" corresponds to the assign Engineer setting, not the in-game unit called "Repair Specialists", which is confusing.
@PabstMirror PabstMirror self-assigned this Jan 19, 2016
@thojkooi thojkooi changed the title acemod/ace3 improve term engineer and repair specialist improve term engineer and repair specialist Jan 20, 2016
@jonpas jonpas added this to the Ongoing milestone Apr 23, 2016
@alganthe
Copy link
Contributor

Where exactly?

@commy2
Copy link
Contributor

commy2 commented Apr 28, 2016

These things should probably be handled by setUnitTrait, but then there are bwc issues again...

@sthyregod
Copy link

As a mission maker (read: Zeus) I would love an option to assign a player as Repair specialist. Kinda missing it atm

@thojkooi
Copy link
Contributor Author

thojkooi commented Mar 8, 2017

This should be changed in string table entries and in the documentation.

We shouldn't replace the variable names to avoid breaking missions.

We are accepting contributions / PRs for this.

@Phyma
Copy link
Contributor

Phyma commented Jun 4, 2017 •
edited
Loading

@PabstMirror "Repair Specialist" to be "Advanced Engineer", does that seem to be reasonable?
and are you working on this?
and what documentation is Glowbal talking about?

@PabstMirror
Copy link
Contributor

Added PR for repair wiki using old term: #5247

I think None, Engineer, Advanced Engineer would work if it fits in 3den attribute.

I was worried about removing old translations, and making new strings to translate.
But I think we could make this a lot easier and leave the old translations in place and just tell our translators to make the changes to existing translations.

@Phyma Phyma mentioned this issue Jun 5, 2017
Merged
Phyma added a commit to Phyma/ACE3 that referenced this issue Jun 5, 2017
@Phyma
Added docs + PR fixes acemod#3186
69a9b52
PabstMirror pushed a commit that referenced this issue Jun 8, 2017
@Phyma @PabstMirror
Repair specialist rename, fixes #3186 (#5248)
55df8bc 
* Changed name

* Fixed Enginner only german and removed big letters

* Added docs + PR fixes #3186

* Removed other languages

* Fixed request and added comment

* Replace all usage of term "Specialist"
@PabstMirror PabstMirror removed their assignment Jun 8, 2017
@PabstMirror PabstMirror modified the milestones: 3.10.0, Ongoing Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation kind/task
Projects
None yet
Milestone
3.10.0
Development

No branches or pull requests
7 participants
@sthyregod @thojkooi @Phyma @commy2 @jonpas @PabstMirror @alganthe