Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair specialist rename, fixes #3186 #5248

Merged
merged 6 commits into from
Jun 8, 2017
Merged

Conversation

Phyma
Copy link
Contributor

@Phyma Phyma commented Jun 5, 2017

When merged this pull request will:

  • Will change the translation from Repair specialist to Advanced Engineer. See picture.
  • Translation on other languages than English might be weird so if its your native language and wrong then please review.

Did not have time to look through all stringtables in ACE so if you know there is a mention of ACE repair specialist somewhere else than repair then please say so. Should not be mentioned anywhere else.

http://steamcommunity.com/sharedfiles/filedetails/?id=940226455

Fixes #3186

@Phyma Phyma changed the title Repair rename, fixes #3186 Repair specialist rename, fixes #3186 Jun 5, 2017
bux
bux previously requested changes Jun 5, 2017
Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better change the english text only and remove the other languages. There a some errors in the german translation.

I'd leave translations to native speakers.

@Phyma Phyma mentioned this pull request Jun 5, 2017
@PabstMirror
Copy link
Contributor

untitled

cut off in 3den (top row)

adding
sizeEx = "3.5 * (1 / (getResolution select 3)) * pixelGrid * 0.5"; // 4.32 default
to line 18 of CfgEden.hpp gives bottom row

@PabstMirror PabstMirror closed this Jun 5, 2017
@PabstMirror PabstMirror reopened this Jun 5, 2017
@jonpas
Copy link
Member

jonpas commented Jun 5, 2017

What about just using Adv. Engineer?

@Phyma
Copy link
Contributor Author

Phyma commented Jun 5, 2017

hehe yeah i wrote that in private to PabstMirror :P But yeah thinking about Adv. Engineer aswell :)

Will make that change when im done with what im doing :P Hate jumping branshes when you are mid of bug fixing :P

@jonpas
Copy link
Member

jonpas commented Jun 5, 2017

git stash to the rescue. ;)

@Phyma
Copy link
Contributor Author

Phyma commented Jun 5, 2017

Fixed!

@PabstMirror PabstMirror added this to the 3.10.0 milestone Jun 8, 2017
@PabstMirror PabstMirror added kind/translation Release Notes: **TRANSLATIONS:** kind/cleanup Release Notes: **CHANGED:** labels Jun 8, 2017
@PabstMirror PabstMirror merged commit 55df8bc into acemod:master Jun 8, 2017
@Phyma
Copy link
Contributor Author

Phyma commented Jun 8, 2017

Okey so we did this. Thoguth that we didnt want to change the variables to not break things. But might have been mistaken

@PabstMirror
Copy link
Contributor

Fixed all usage of those stringnames in ace.
Should help when they get re-translated (avoid people using the old term again)

@Phyma Phyma deleted the repairRename branch June 8, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:** kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants