Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CBA Misc Items #5502

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Use CBA Misc Items #5502

merged 2 commits into from
Sep 13, 2017

Conversation

PabstMirror
Copy link
Contributor

For CBATeam/CBA_A3#744

class ACE_ItemCore: CBA_MiscItem {};

Should we keep ACE_ItemCore or just drop it and use the CBA item base for everything?

@jonpas
Copy link
Member

jonpas commented Sep 11, 2017

Might be wise to keep it, in case we add something else specific to ACE3 to all items in the future.

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with CBA 3.4.1, all looks good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants