Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gx2f): forward propagation error #3296

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

AJPfleger
Copy link
Contributor

Somehow the GX2F was so perfect, that no errors occurred until I got today

terminate called after throwing an instance of 'std::bad_variant_access'
 what():  std::get: wrong index for variant

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.31%. Comparing base (06c2b63) to head (fd13678).
Report is 267 commits behind head on main.

Files with missing lines Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   47.31%   47.31%   -0.01%     
==========================================
  Files         512      512              
  Lines       30434    30437       +3     
  Branches    14793    14795       +2     
==========================================
  Hits        14400    14400              
- Misses       5402     5404       +2     
- Partials    10632    10633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 1e0f2f1 into acts-project:main Jun 16, 2024
54 checks passed
@AJPfleger AJPfleger deleted the propagation-error branch June 16, 2024 09:12
@andiwand andiwand modified the milestones: next, v35.2.0 Jun 16, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jun 16, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
Somehow the GX2F was so perfect, that no errors occurred until I got today
```
terminate called after throwing an instance of 'std::bad_variant_access'
 what():  std::get: wrong index for variant
```
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
Somehow the GX2F was so perfect, that no errors occurred until I got today
```
terminate called after throwing an instance of 'std::bad_variant_access'
 what():  std::get: wrong index for variant
```
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants