Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gx2f): logic for multipleScattering option (no effect yet) #3551

Merged
merged 7 commits into from
Aug 26, 2024
Merged

refactor(gx2f): logic for multipleScattering option (no effect yet) #3551

merged 7 commits into from
Aug 26, 2024

Conversation

AJPfleger
Copy link
Contributor

This prepares the logic for the multiple scattering. I pulled it out of the scattering implementation.

This also gives a better solution for updating the jacobianFromStart and therefore closing:

@AJPfleger AJPfleger added this to the next milestone Aug 26, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Aug 26, 2024
This was referenced Aug 26, 2024
Merged
Closed
@AJPfleger AJPfleger marked this pull request as ready for review August 26, 2024 09:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

📊: Physics performance monitoring for f794277

Full contents

physmon summary

andiwand
andiwand approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
38.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 2b4d3df into acts-project:main Aug 26, 2024
44 checks passed
@AJPfleger AJPfleger deleted the gx2f-ms-flag branch August 26, 2024 15:49
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [2b4d3df]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🔴 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🔴 test_ActsBenchmarkWithSpot
🔴 test_ActsAnalogueClustering
🔴 test_ActsWorkflowHeavyIons
🔴 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🔴 test_ActsValidateResolvedTracks
🔴 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🔴 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 26, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2024
@AJPfleger
feat(gx2f): material effects - multiple scattering (#3292)
2493b0e 
blocked by:
- #3293
- #3294
- #3296
- #3551
- #3552
- #3556
- #3566
- #3568
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Milestone
v36.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AJPfleger @acts-project-service @andiwand