-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gx2f): early exit for the Actor #3566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
approved these changes
Aug 27, 2024
@AJPfleger there seems to be a failure in the gitlab ci |
The gitlab CI failure seems unrelated to my changes: 🔴 CKF | trackfinding | ttbar with 200 pileup | default seeding🔴 Ambisolver | trackfinding | ttbar with 200 pileup | default seeding🔴 AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seedingI couldn't see it on main, let's see, if a rerun of the CI fixes it. |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design for the Actor of the GX2F is clear now. Since we have only a clear forward propagation, we can skip all navigation states without a surface. Therefore, we do not need to reserve any options afterwards and early exits are possible.