Reduce package size #3443

MikesGlitch · 2024-09-15T13:18:59Z

Tested on:

Windows
Linux AppImage
Didn't test mac - my VM broke - it should work exactly the same

Before:

After:

netlify · 2024-09-15T13:19:14Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`469b307`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66e71f64422d0d0008da5ff3
😎 Deploy Preview	https://deploy-preview-3443.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-09-15T13:21:13Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.17 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/narrow.js	78.89 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/usePreviewTransactions.js	1.59 kB	0%
static/js/AppliedFilters.js	20.97 kB	0%
static/js/wide.js	225.15 kB	0%
static/js/ReportRouter.js	1.5 MB	0%
static/js/index.js	3.2 MB	0%

github-actions · 2024-09-15T13:21:14Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

MikesGlitch · 2024-09-15T13:28:05Z

packages/desktop-electron/package.json

+      "!**/*.js.map",
+      "!**/stats.json",
+      "!node_modules/@jlongster/sql.js/**/*",
+      "!build/client-build/sql-wasm.wasm"


used in web for @jlongster/sql.js - not required in electron because we use better-sqlite3

matt-fidd

Tested on Win and Linux, can't test MacOS but also can't see anything that would affect it and not the others.

* reduce package size of all packages * release notes * Update beforePackHook.ts

* marked files for translation * added release note * fixed linting warnings * 🐛 fix account filters being overridden (#3441) *

Reduce package size (#3443) * reduce package size of all packages * release notes * Update beforePackHook.ts * [Maintenance] Cleanup react aria packages and dedupe (#3450) * Cleanup react aria packages and dedupe * Release notes * ♻️ (synced-prefs) moving the prefs from metadata.json to the db (#3423) *

Restart server silently when adding self signed cert and add some logs (#3431) * restart server silently on add self signed cert and add some logging * release notes * fix name * updating names to be more specific * removing setloading * feedback * ♻️ (synced-prefs) move budget type to synced prefs (#3427) * update synced account balance in db if available (#3452) * 🐛 (synced-prefs) fix bulk-reading not working in import modal (#3460) * fix: csv import deduplication (#3456) * ✨ release simplefin as a first-party feature (#3459) Closes #2272 * Do not allow renaming to an empty category or group name (#3463) * Do not allow renaming to an emoty category or group name * Release notes * [Mobile] Fix #3214 - Pull down to refresh triggering clicks on budget cells (#3374) * Fix #3214 * Fix rollover indicator * VRT * Fix typecheck error * VRT * Release notes * VRT * Update style * Fix budgeted * VRT * VRT * Revert VRT * VRT * Fix style * Revert usePreviewTransactions * Fix error * Fix reports form submit handlers (#3462) * Fix form submit handlers * Release notes *

Remove some old updater code (#3468) * remove some old updater code * remove old updater logic * CSV import e2e tests (#3467) * Fix React Aria Button hover styles (#3453) * Fiox hover styles and use className instead of inline to prepare for future css migration * Release notes * Cleanup * Update edit rule hover style * Undoable auto transfer notes + auto notes for cover (#3411) * Undo auto transfer notes + auto notes for cover * Release notes * Fix notes * Fix notes undo * Do not show clicked category on transfer or cover menus * Fix typecheck error * typecheck * Fix removeCategoriesFromGroups * 🐛 (reports) deleting custom report should remove it from the dashboard (#3469) * Revert "CSV import e2e tests (#3467)" (#3474) This reverts commit 5e12d40. * ♻️ (synced-prefs) separate metadata and local prefs out (#3458) *

Replace deprecated file protocol registration (#3475) * replace deprecated file handler in electron * release notes * types eh * types * update sql regexp to default to empty string when field is null (#3480) * ♻️ rename report/rollover budget to tracking/envelope (#3483) * 🐛 (import) fix csv import checkboxes not working (#3478) * Update tooltip and themes with better visibility (#3298) * Update tooltip and themes with better visibility * Rename merge request # into release notes * rename release note * update VRT * tweak light theme * dont put border on autocomplete menus * update VRT * tweak popover style * simplify * update VRT * update VRT --------- Co-authored-by: Dustin Conlon <dustin@dustinconlon.com> Co-authored-by: Dustin Conlon <58367364+VoltaicGRiD@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * fix modals on mobile BudgetTable (#3487) * Fix privacy filter (#3472) * Fix privacy filter * Release notes * Coderabbit suggestion * VRT * VRT * Revert VRT * VRT * VRT * VRT * VRT * Delete VRT * VRT * Revert VRT * 🐛 fix custom reports crashing when opening table (#3484) * 🧪 (tests) adding custom report e2e tests (#3493) * ✨ (dashboards) ability to save filters & timeframes on spending widgets (#3432) * marked files for translation * Revert ":bug: fix account filters being overridden (#3441)" This reverts commit 7336bad. * Revert "Revert ":bug: fix account filters being overridden (#3441)"" This reverts commit 5cbadc4. * Revert changes due to failed rebase * removed import of t * fixed lint warning * added PayeeTableRow.tsx * needed changes * bugfix: pluralization * variables adjustments * removed doubled trans --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> Co-authored-by: Koen van Staveren <koenvanstaveren@hotmail.com> Co-authored-by: Ryan Bianchi <1435081+qedi-r@users.noreply.github.com> Co-authored-by: Robert Dyer <rdyer@unl.edu> Co-authored-by: Dustin Conlon <dustin@dustinconlon.com> Co-authored-by: Dustin Conlon <58367364+VoltaicGRiD@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Tim <hello@timsmart.co>

reduce package size of all packages

df3280e

actual-github-bot bot added the 🚧 WIP label Sep 15, 2024

release notes

82a5300

MikesGlitch changed the title ~~Reduce package size~~ Reduce package size Sep 15, 2024

MikesGlitch commented Sep 15, 2024

View reviewed changes

MikesGlitch marked this pull request as ready for review September 15, 2024 14:01

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Sep 15, 2024

Update beforePackHook.ts

469b307

matt-fidd approved these changes Sep 16, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Sep 16, 2024

MikesGlitch merged commit ae01066 into actualbudget:master Sep 16, 2024
19 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Sep 16, 2024

MikesGlitch deleted the electron/reduce-package-size branch September 16, 2024 18:12

a-gradina pushed a commit to a-gradina/actual that referenced this pull request Sep 24, 2024

Reduce package size (actualbudget#3443)

e13f467

* reduce package size of all packages * release notes * Update beforePackHook.ts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce package size #3443

Reduce package size #3443

MikesGlitch commented Sep 15, 2024 •

edited

Loading

netlify bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 15, 2024 •

edited

Loading

MikesGlitch Sep 15, 2024 •

edited

Loading

matt-fidd left a comment

Reduce package size #3443

Reduce package size #3443

Conversation

MikesGlitch commented Sep 15, 2024 • edited Loading

netlify bot commented Sep 15, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Sep 15, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Sep 15, 2024 • edited Loading

Bundle Stats — loot-core

MikesGlitch Sep 15, 2024 • edited Loading

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

MikesGlitch commented Sep 15, 2024 •

edited

Loading

netlify bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 15, 2024 •

edited

Loading

github-actions bot commented Sep 15, 2024 •

edited

Loading

MikesGlitch Sep 15, 2024 •

edited

Loading