fix: csv import deduplication #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
UnderKoen
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
WalkthroughThe changes introduced in this pull request focus on improving the handling of transaction data in the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 Thanks for working on this! Would you have an example CSV file I could use for testing the patch? That would help me greatly 🙏 |
|
Vanguard-401k.csv |
|
@coderabbitai review |
Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx (1)
926-927: Validation looks good, but consider enhancing the error message.The null and type check for
trans.payee_nameis a good defensive programming practice. However, consider including additional context in the error message, such as the transaction date or amount, to make debugging easier.For example:
-console.log(`Unable·to·parse·payee·${trans.payee_name || '(empty)'}`); +console.log(`Unable to parse payee "${trans.payee_name || '(empty)'}" for transaction on ${trans.date} with amount ${trans.amount}`);
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx (3 hunks)
- upcoming-release-notes/3456.md (1 hunks)
Additional comments not posted (3)
upcoming-release-notes/3456.md (1)
1-6: Release note looks good!The release note follows the correct structure and provides a clear and concise description of the bug fix. The metadata in the YAML front matter is accurate, and the issue number is correctly referenced.
Great job on documenting this fix!
packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx (2)
4-4: LGTM!Importing the
deepEqualfunction from thedeep-equalpackage is a good practice for performing deep equality comparisons.
1383-1386: Looks good to me!Using
deepEqualfor comparing the current and new transactions state is the right approach. Updating the state only when there's an actual change avoids unnecessary re-renders and improves performance. TheuseCallbackdependencies also look correct.
|
Thanks! I noticed another bug here (introduced by me). We'll need to merge this PR first and then I'll return back to your PR. Apologies about the delay. |
MatissJanis
approved these changes
Sep 18, 2024
This was referenced Sep 18, 2024
Merged
a-gradina
pushed a commit
to a-gradina/actual
that referenced
this pull request
Sep 24, 2024
matt-fidd
added a commit
that referenced
this pull request
Oct 3, 2024
* marked files for translation * added release note * fixed linting warnings * 🐛 fix account filters being overridden (#3441) *Reduce package size (#3443) * reduce package size of all packages * release notes * Update beforePackHook.ts * [Maintenance] Cleanup react aria packages and dedupe (#3450) * Cleanup react aria packages and dedupe * Release notes * ♻️ (synced-prefs) moving the prefs from metadata.json to the db (#3423) *
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3416