🐛 fix custom reports crashing when opening table #3484

MatissJanis · 2024-09-22T20:03:35Z

State mutations should not be happening during render cycle.

Reproduction:

create custom report (type: table)
save it
open the main reports page
click on the saved custom report
💥

coderabbitai · 2024-09-22T20:03:45Z

Walkthrough

The CustomReport component has been updated to enhance state management. A comment was added to the getGraphData function regarding state mutations within the useMemo hook. The introduction of a useEffect hook manages the states of viewLegendPref and viewLabelsPref based on the disabledLegendLabel function, which assesses the current mode and graphType. The isItemDisabled function was simplified to rely on the return value from disabledLegendLabel for determining item states.

Changes

File	Change Summary
`packages/desktop-client/src/components/reports/reports/CustomReport.tsx`	Added a comment to `getGraphData`, introduced `useEffect` for managing state preferences, and simplified `isItemDisabled` logic.

Possibly related PRs

🐛 (reports) deleting custom report should remove it from the dashboard #3469: Changes in CustomReportListCards.tsx may connect to CustomReport.tsx, as both are part of the reports feature and involve state management.

Suggested labels

:sparkles: Merged

Suggested reviewers

joel-jeremy

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-09-22T20:03:50Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`dbd5cb8`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66f08d2878ae0f00082e4ac7
😎 Deploy Preview	https://deploy-preview-3484.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-09-22T20:04:53Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.29 MB → 5.29 MB (+92 B)	+0.00%

Changeset

File	Δ	Size
`src/components/reports/reports/CustomReport.tsx`	📈 +92 B (+0.40%)	22.36 kB → 22.45 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.5 MB → 1.5 MB (+92 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/usePreviewTransactions.js	1.59 kB	0%
static/js/AppliedFilters.js	20.97 kB	0%
static/js/narrow.js	81.02 kB	0%
static/js/wide.js	225.4 kB	0%
static/js/index.js	3.31 MB	0%

github-actions · 2024-09-22T20:04:53Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 09e3721 and fc5c99f.

Files ignored due to path filters (1)

upcoming-release-notes/3484.md is excluded by !**/*.md

Files selected for processing (1)

packages/desktop-client/src/components/reports/reports/CustomReport.tsx (2 hunks)

Additional comments not posted (1)

packages/desktop-client/src/components/reports/reports/CustomReport.tsx (1)

458-466: Proper usage of useEffect to manage side effects.

The introduction of the useEffect hook is a good practice to manage side effects in functional components. The effect correctly updates the state of viewLegendPref and viewLabelsPref based on the result of the disabledLegendLabel function.

The dependencies array [setViewLegendPref, setViewLabelsPref, mode, graphType] is correctly specified, ensuring that the effect runs when the component mounts and whenever any of these dependencies change.

packages/desktop-client/src/components/reports/reports/CustomReport.tsx

carkom · 2024-09-23T14:54:36Z

Seems like a fairly major bug, I'm surprised you're the first one to point it out. Thanks for finding it and calling it out.

carkom

LGTM

* marked files for translation * added release note * fixed linting warnings * 🐛 fix account filters being overridden (#3441) *

Reduce package size (#3443) * reduce package size of all packages * release notes * Update beforePackHook.ts * [Maintenance] Cleanup react aria packages and dedupe (#3450) * Cleanup react aria packages and dedupe * Release notes * ♻️ (synced-prefs) moving the prefs from metadata.json to the db (#3423) *

Restart server silently when adding self signed cert and add some logs (#3431) * restart server silently on add self signed cert and add some logging * release notes * fix name * updating names to be more specific * removing setloading * feedback * ♻️ (synced-prefs) move budget type to synced prefs (#3427) * update synced account balance in db if available (#3452) * 🐛 (synced-prefs) fix bulk-reading not working in import modal (#3460) * fix: csv import deduplication (#3456) * ✨ release simplefin as a first-party feature (#3459) Closes #2272 * Do not allow renaming to an empty category or group name (#3463) * Do not allow renaming to an emoty category or group name * Release notes * [Mobile] Fix #3214 - Pull down to refresh triggering clicks on budget cells (#3374) * Fix #3214 * Fix rollover indicator * VRT * Fix typecheck error * VRT * Release notes * VRT * Update style * Fix budgeted * VRT * VRT * Revert VRT * VRT * Fix style * Revert usePreviewTransactions * Fix error * Fix reports form submit handlers (#3462) * Fix form submit handlers * Release notes *

Remove some old updater code (#3468) * remove some old updater code * remove old updater logic * CSV import e2e tests (#3467) * Fix React Aria Button hover styles (#3453) * Fiox hover styles and use className instead of inline to prepare for future css migration * Release notes * Cleanup * Update edit rule hover style * Undoable auto transfer notes + auto notes for cover (#3411) * Undo auto transfer notes + auto notes for cover * Release notes * Fix notes * Fix notes undo * Do not show clicked category on transfer or cover menus * Fix typecheck error * typecheck * Fix removeCategoriesFromGroups * 🐛 (reports) deleting custom report should remove it from the dashboard (#3469) * Revert "CSV import e2e tests (#3467)" (#3474) This reverts commit 5e12d40. * ♻️ (synced-prefs) separate metadata and local prefs out (#3458) *

Replace deprecated file protocol registration (#3475) * replace deprecated file handler in electron * release notes * types eh * types * update sql regexp to default to empty string when field is null (#3480) * ♻️ rename report/rollover budget to tracking/envelope (#3483) * 🐛 (import) fix csv import checkboxes not working (#3478) * Update tooltip and themes with better visibility (#3298) * Update tooltip and themes with better visibility * Rename merge request # into release notes * rename release note * update VRT * tweak light theme * dont put border on autocomplete menus * update VRT * tweak popover style * simplify * update VRT * update VRT --------- Co-authored-by: Dustin Conlon <dustin@dustinconlon.com> Co-authored-by: Dustin Conlon <58367364+VoltaicGRiD@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * fix modals on mobile BudgetTable (#3487) * Fix privacy filter (#3472) * Fix privacy filter * Release notes * Coderabbit suggestion * VRT * VRT * Revert VRT * VRT * VRT * VRT * VRT * Delete VRT * VRT * Revert VRT * 🐛 fix custom reports crashing when opening table (#3484) * 🧪 (tests) adding custom report e2e tests (#3493) * ✨ (dashboards) ability to save filters & timeframes on spending widgets (#3432) * marked files for translation * Revert ":bug: fix account filters being overridden (#3441)" This reverts commit 7336bad. * Revert "Revert ":bug: fix account filters being overridden (#3441)"" This reverts commit 5cbadc4. * Revert changes due to failed rebase * removed import of t * fixed lint warning * added PayeeTableRow.tsx * needed changes * bugfix: pluralization * variables adjustments * removed doubled trans --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> Co-authored-by: Koen van Staveren <koenvanstaveren@hotmail.com> Co-authored-by: Ryan Bianchi <1435081+qedi-r@users.noreply.github.com> Co-authored-by: Robert Dyer <rdyer@unl.edu> Co-authored-by: Dustin Conlon <dustin@dustinconlon.com> Co-authored-by: Dustin Conlon <58367364+VoltaicGRiD@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Tim <hello@timsmart.co>

🐛 fix custom reports crashing when opening table

fc5c99f

actual-github-bot bot changed the title ~~🐛 fix custom reports crashing when opening table~~ [WIP] 🐛 fix custom reports crashing when opening table Sep 22, 2024

actual-github-bot bot added the 🚧 WIP label Sep 22, 2024

MatissJanis requested a review from carkom September 22, 2024 20:04

coderabbitai bot reviewed Sep 22, 2024

View reviewed changes

packages/desktop-client/src/components/reports/reports/CustomReport.tsx Show resolved Hide resolved

Merge branch 'master' into matiss/custom-reports-fix

dbd5cb8

MatissJanis changed the title ~~[WIP] 🐛 fix custom reports crashing when opening table~~ 🐛 fix custom reports crashing when opening table Sep 22, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Sep 22, 2024

youngcw added this to the v24.10.0 milestone Sep 23, 2024

carkom reviewed Sep 23, 2024

View reviewed changes

packages/desktop-client/src/components/reports/reports/CustomReport.tsx Show resolved Hide resolved

MikesGlitch approved these changes Sep 23, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Sep 23, 2024

carkom approved these changes Sep 23, 2024

View reviewed changes

MatissJanis merged commit 37d201b into master Sep 23, 2024
20 checks passed

MatissJanis deleted the matiss/custom-reports-fix branch September 23, 2024 20:10

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Sep 23, 2024

a-gradina pushed a commit to a-gradina/actual that referenced this pull request Sep 24, 2024

🐛 fix custom reports crashing when opening table (actualbudget#3484)

f3cc1e1

coderabbitai bot mentioned this pull request Oct 4, 2024

🐛 (reports) fix reports page having empty blocks #3566

Merged

coderabbitai bot mentioned this pull request Oct 27, 2024

♻️ custom reports - moving to url identifiers #3744

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 fix custom reports crashing when opening table #3484

🐛 fix custom reports crashing when opening table #3484

MatissJanis commented Sep 22, 2024

coderabbitai bot commented Sep 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

coderabbitai bot left a comment

carkom commented Sep 23, 2024

carkom left a comment

🐛 fix custom reports crashing when opening table #3484

🐛 fix custom reports crashing when opening table #3484

Conversation

MatissJanis commented Sep 22, 2024

coderabbitai bot commented Sep 22, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Sep 22, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Sep 22, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Sep 22, 2024 • edited Loading

Bundle Stats — loot-core

coderabbitai bot left a comment

Choose a reason for hiding this comment

carkom commented Sep 23, 2024

carkom left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Sep 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading